HBASE-25032 Do not assign regions to region server which has not call… #3268

Apache9 · 2021-05-14T15:04:53Z

…ed regionServerReport yet

Apache9 · 2021-05-14T15:09:54Z

As ServerMetrics is IA.Public, so do not want to add more methods to it only for an intrnal optimization.

The trick is straight forward, in regionServerStartup, the LastReportTimestamp of the created ServerMetrics will be 0, while in regionServerReport, it will be set at region server side so should be a positive value. We could use this value to determine whether a region server has called regionServerReport or not, so we can exclude the region servers which have not called regionServerReport in ServerManager.createDestinationServersList.

Added two UTs, one is to make sure we do not assign regions to a region server which has not called regionServerReport yet. The other is to make sure that we will not change the meaning of online servers, as what we have done wrong in the first PR for HBASE-25032.

Thanks.

Apache-HBase · 2021-05-14T16:03:44Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 59s	master passed
+1 💚	compile	4m 21s	master passed
+1 💚	checkstyle	1m 28s	master passed
+1 💚	spotbugs	3m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 45s	the patch passed
+1 💚	compile	4m 8s	the patch passed
+1 💚	javac	4m 8s	the patch passed
-0 ⚠️	checkstyle	1m 4s	hbase-server: The patch generated 3 new + 14 unchanged - 0 fixed = 17 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 16s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 35s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 25s	The patch does not generate ASF License warnings.
		57m 53s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 7a6b79f5ada9 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6c3eca`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-14T18:19:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 51s	master passed
+1 💚	compile	1m 28s	master passed
+1 💚	shadedjars	8m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 44s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	8m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 14s	hbase-client in the patch passed.
-1 ❌	unit	160m 19s	hbase-server in the patch failed.
		193m 42s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux c062e7995bcc 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6c3eca`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/testReport/
Max. process+thread count	4265 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-14T18:33:02Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 35s	master passed
+1 💚	compile	1m 49s	master passed
+1 💚	shadedjars	8m 25s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 9s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 27s	the patch passed
+1 💚	compile	1m 45s	the patch passed
+1 💚	javac	1m 45s	the patch passed
+1 💚	shadedjars	8m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 23s	hbase-client in the patch passed.
-1 ❌	unit	170m 52s	hbase-server in the patch failed.
		207m 10s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux ae99c14e2e6d 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `f6c3eca`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/testReport/
Max. process+thread count	4059 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/1/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

bharathv

nice patch, simple and neat, makes sense to me.

bharathv · 2021-05-14T19:35:14Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java

+    Set<ServerName> destServers = new HashSet<>();
+    onlineServers.forEach((sn, sm) -> {
+      if (sm.getLastReportTimestamp() > 0) {
+        // This means we have already called regionServerReport at leaset once, then let's include


nit: 'least' typo.

bharathv · 2021-05-14T19:46:57Z

Test failures seem related?

Apache9 · 2021-05-14T23:48:58Z

Test failures seem related?

Yes, should be related. Let me see how to fix the UTs.

Apache-HBase · 2021-05-15T11:13:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 53s	master passed
+1 💚	compile	4m 7s	master passed
+1 💚	checkstyle	1m 31s	master passed
+1 💚	spotbugs	3m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 39s	the patch passed
+1 💚	compile	4m 6s	the patch passed
+1 💚	javac	4m 6s	the patch passed
+1 💚	checkstyle	1m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 3s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 27s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 27s	The patch does not generate ASF License warnings.
		53m 29s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 4833a65b0d11 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8ae4d65`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-15T13:26:37Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 35s	master passed
+1 💚	compile	1m 38s	master passed
+1 💚	shadedjars	9m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 14s	the patch passed
+1 💚	compile	1m 37s	the patch passed
+1 💚	javac	1m 37s	the patch passed
+1 💚	shadedjars	8m 17s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 12s	hbase-client in the patch passed.
-1 ❌	unit	150m 55s	hbase-server in the patch failed.
		186m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3de9c5562a9b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8ae4d65`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/testReport/
Max. process+thread count	4220 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-15T14:41:20Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 56s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 26s	Maven dependency ordering for branch
+1 💚	mvninstall	6m 15s	master passed
+1 💚	compile	2m 28s	master passed
+1 💚	shadedjars	12m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 35s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 18s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 18s	the patch passed
+1 💚	compile	2m 31s	the patch passed
+1 💚	javac	2m 31s	the patch passed
+1 💚	shadedjars	10m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 8s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 39s	hbase-client in the patch passed.
-1 ❌	unit	210m 40s	hbase-server in the patch failed.
		261m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 03aa8f82b82f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `8ae4d65`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/testReport/
Max. process+thread count	3529 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/2/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache9 · 2021-05-15T15:06:02Z

TestRSGroupKillRS is broken. Still digging...

Apache-HBase · 2021-05-16T14:55:51Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 16s	master passed
+1 💚	compile	4m 15s	master passed
+1 💚	checkstyle	1m 38s	master passed
+1 💚	spotbugs	3m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 12s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	4m 14s	the patch passed
+1 💚	javac	4m 14s	the patch passed
+1 💚	checkstyle	1m 38s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	19m 59s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 34s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 22s	The patch does not generate ASF License warnings.
		57m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux e57e409a042f 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `85d8ec7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	86 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-16T17:00:48Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 29s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 30s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 36s	master passed
+1 💚	compile	1m 30s	master passed
+1 💚	shadedjars	8m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 1s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	1m 27s	the patch passed
+1 💚	javac	1m 27s	the patch passed
+1 💚	shadedjars	8m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 0s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 12s	hbase-client in the patch passed.
-1 ❌	unit	148m 50s	hbase-server in the patch failed.
		182m 30s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 125d3dba87f6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `85d8ec7`
Default Java	AdoptOpenJDK-1.8.0_282-b08
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/testReport/
Max. process+thread count	4445 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-16T18:08:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 8s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 23s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 42s	master passed
+1 💚	compile	1m 47s	master passed
+1 💚	shadedjars	8m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 46s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	shadedjars	8m 58s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 39s	hbase-client in the patch passed.
-1 ❌	unit	211m 40s	hbase-server in the patch failed.
		250m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cf1939d3ed4a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `85d8ec7`
Default Java	AdoptOpenJDK-11.0.10+9
unit	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/testReport/
Max. process+thread count	2970 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/3/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

saintstack

Nice.

One nit.

saintstack · 2021-05-17T07:06:34Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java

@@ -76,7 +76,7 @@
  private MasterServices masterServices;
  private FavoredNodesManager favoredNodesManager;
  private volatile RSGroupInfoManager rsGroupInfoManager;
-  private LoadBalancer internalBalancer;
+  private volatile LoadBalancer internalBalancer;


This belongs in this patch?

In general, no.

But this is also a fix on the balancer implementation and this patch will be applied to all active branches I believe, so I think it is OK to also include these minor changes.

…ed regionServerReport yet

Apache-HBase · 2021-05-17T11:37:30Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	11m 19s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 10s	master passed
+1 💚	compile	4m 30s	master passed
+1 💚	checkstyle	1m 42s	master passed
+1 💚	spotbugs	3m 14s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 48s	the patch passed
+1 💚	compile	4m 18s	the patch passed
+1 💚	javac	4m 18s	the patch passed
-0 ⚠️	checkstyle	1m 7s	hbase-server: The patch generated 1 new + 14 unchanged - 0 fixed = 15 total (was 14)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	20m 8s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 31s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 26s	The patch does not generate ASF License warnings.
		68m 7s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 0f298a57200c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-17T13:34:10Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 0s	master passed
+1 💚	compile	1m 59s	master passed
+1 💚	shadedjars	9m 36s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 17s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 29s	the patch passed
+1 💚	compile	1m 47s	the patch passed
+1 💚	javac	1m 47s	the patch passed
+1 💚	shadedjars	9m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 13s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 31s	hbase-client in the patch passed.
+1 💚	unit	145m 10s	hbase-server in the patch passed.
		184m 50s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6102a1fa918e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/testReport/
Max. process+thread count	4158 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-17T14:47:45Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 39s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 27s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 49s	master passed
+1 💚	compile	1m 46s	master passed
+1 💚	shadedjars	9m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 10s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 47s	the patch passed
+1 💚	compile	1m 49s	the patch passed
+1 💚	javac	1m 49s	the patch passed
+1 💚	shadedjars	9m 12s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 27s	hbase-client in the patch passed.
+1 💚	unit	217m 51s	hbase-server in the patch passed.
		258m 24s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux abd77e2dd15d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/testReport/
Max. process+thread count	3062 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/4/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-17T15:43:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for branch
+1 💚	mvninstall	3m 37s	master passed
+1 💚	compile	4m 5s	master passed
+1 💚	checkstyle	1m 29s	master passed
+1 💚	spotbugs	2m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	3m 35s	the patch passed
+1 💚	compile	4m 6s	the patch passed
+1 💚	javac	4m 6s	the patch passed
+1 💚	checkstyle	1m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	18m 44s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚	spotbugs	3m 32s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 24s	The patch does not generate ASF License warnings.
		53m 54s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname	Linux 1164080c984c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count	96 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/console
versions	git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-17T17:57:24Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 44s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 51s	master passed
+1 💚	compile	2m 10s	master passed
+1 💚	shadedjars	11m 17s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 24s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 19s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 46s	the patch passed
+1 💚	compile	2m 7s	the patch passed
+1 💚	javac	2m 7s	the patch passed
+1 💚	shadedjars	10m 38s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 47s	hbase-client in the patch passed.
+1 💚	unit	140m 59s	hbase-server in the patch passed.
		187m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 269ddcd61a89 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-11.0.10+9
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/testReport/
Max. process+thread count	4894 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2021-05-17T19:02:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 28s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+0 🆗	mvndep	0m 16s	Maven dependency ordering for branch
+1 💚	mvninstall	4m 7s	master passed
+1 💚	compile	1m 34s	master passed
+1 💚	shadedjars	9m 16s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 58s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	4m 2s	the patch passed
+1 💚	compile	1m 29s	the patch passed
+1 💚	javac	1m 29s	the patch passed
+1 💚	shadedjars	8m 54s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 26s	hbase-client in the patch passed.
+1 💚	unit	215m 40s	hbase-server in the patch passed.
		252m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#3268
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 6e84cbef442e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `2126ec9`
Default Java	AdoptOpenJDK-1.8.0_282-b08
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/testReport/
Max. process+thread count	3220 (vs. ulimit of 30000)
modules	C: hbase-client hbase-server U: .
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3268/5/console
versions	git=2.17.1 maven=3.6.3
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

…ed regionServerReport yet (#3268) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>

…not called regionServerReport yet (#3268)" This reverts commit 2bf8646.

…not called regionServerReport yet (#3268)" This reverts commit 852f479.

…which has not called regionServerReport yet (apache#3268) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>

Apache9 self-assigned this May 14, 2021

Apache9 requested review from bharathv, apurtell and saintstack May 14, 2021 15:09

bharathv approved these changes May 14, 2021

View reviewed changes

Apache9 force-pushed the HBASE-25032 branch from 8ef305c to 43d461a Compare May 15, 2021 10:18

saintstack approved these changes May 17, 2021

View reviewed changes

HBASE-25032 Do not assign regions to region server which has not call…

7bdba40

…ed regionServerReport yet

Apache9 force-pushed the HBASE-25032 branch from 1da9d68 to 7bdba40 Compare May 17, 2021 10:28

fix checkstyle

01d9e60

Apache9 merged commit 741b4b4 into apache:master May 18, 2021

Apache9 added a commit that referenced this pull request May 18, 2021

HBASE-25032 Do not assign regions to region server which has not call…

852f479

…ed regionServerReport yet (#3268) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>

Apache9 added a commit that referenced this pull request May 18, 2021

HBASE-25032 Do not assign regions to region server which has not call…

2bf8646

…ed regionServerReport yet (#3268) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>

Apache9 added a commit that referenced this pull request May 18, 2021

HBASE-25032 Do not assign regions to region server which has not call…

8110b18

…ed regionServerReport yet (#3268) Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Michael Stack <[email protected]>

asfgit pushed a commit that referenced this pull request May 19, 2021

Revert "HBASE-25032 Do not assign regions to region server which has …

2fec951

…not called regionServerReport yet (#3268)" This reverts commit 2bf8646.

Apache9 added a commit that referenced this pull request May 20, 2021

Revert "HBASE-25032 Do not assign regions to region server which has …

c4f790a

…not called regionServerReport yet (#3268)" This reverts commit 852f479.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-25032 Do not assign regions to region server which has not call… #3268

HBASE-25032 Do not assign regions to region server which has not call… #3268

Apache9 commented May 14, 2021

Apache9 commented May 14, 2021

Apache-HBase commented May 14, 2021

Apache-HBase commented May 14, 2021

Apache-HBase commented May 14, 2021

bharathv left a comment

bharathv May 14, 2021

bharathv commented May 14, 2021

Apache9 commented May 14, 2021

Apache-HBase commented May 15, 2021

Apache-HBase commented May 15, 2021

Apache-HBase commented May 15, 2021

Apache9 commented May 15, 2021

Apache-HBase commented May 16, 2021

Apache-HBase commented May 16, 2021

Apache-HBase commented May 16, 2021

saintstack left a comment

saintstack May 17, 2021

Apache9 May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

HBASE-25032 Do not assign regions to region server which has not call… #3268

HBASE-25032 Do not assign regions to region server which has not call… #3268

Conversation

Apache9 commented May 14, 2021

Apache9 commented May 14, 2021

Apache-HBase commented May 14, 2021

Apache-HBase commented May 14, 2021

Apache-HBase commented May 14, 2021

bharathv left a comment

Choose a reason for hiding this comment

bharathv May 14, 2021

Choose a reason for hiding this comment

bharathv commented May 14, 2021

Apache9 commented May 14, 2021

Apache-HBase commented May 15, 2021

Apache-HBase commented May 15, 2021

Apache-HBase commented May 15, 2021

Apache9 commented May 15, 2021

Apache-HBase commented May 16, 2021

Apache-HBase commented May 16, 2021

Apache-HBase commented May 16, 2021

saintstack left a comment

Choose a reason for hiding this comment

saintstack May 17, 2021

Choose a reason for hiding this comment

Apache9 May 17, 2021

Choose a reason for hiding this comment

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021

Apache-HBase commented May 17, 2021