Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-25757 Move BaseLoadBalancer to hbase-balancer module #3191

Merged
merged 1 commit into from
Apr 26, 2021
Merged

HBASE-25757 Move BaseLoadBalancer to hbase-balancer module #3191

merged 1 commit into from
Apr 26, 2021

Conversation

Apache9
Copy link
Contributor

@Apache9 Apache9 commented Apr 22, 2021

No description provided.

@Apache9 Apache9 self-assigned this Apr 22, 2021
@Apache9
Copy link
Contributor Author

Apache9 commented Apr 22, 2021

Put it here first. I think we could land some pre patches first before landing this patch, where the pre patches could be landed to branch-2 too.

And we can not move the tests to hbase-balancer for now, as the in the base test class we make use of StochasticLoadBalancer, and it uses a NamedQueueRecorder which is in hbase-server. Will refactor in later PRs to also move StochasticLoadBalancer and related test code to hbase-balancer.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 24s Maven dependency ordering for branch
+1 💚 mvninstall 3m 52s master passed
+1 💚 compile 3m 33s master passed
+1 💚 checkstyle 1m 20s master passed
+1 💚 spotbugs 2m 37s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 13s Maven dependency ordering for patch
+1 💚 mvninstall 3m 32s the patch passed
+1 💚 compile 3m 30s the patch passed
-0 ⚠️ javac 0m 26s hbase-balancer generated 5 new + 31 unchanged - 0 fixed = 36 total (was 31)
-0 ⚠️ checkstyle 0m 13s hbase-balancer: The patch generated 29 new + 0 unchanged - 0 fixed = 29 total (was 0)
+1 💚 checkstyle 1m 5s hbase-server: The patch generated 0 new + 29 unchanged - 30 fixed = 29 total (was 59)
-0 ⚠️ whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚 hadoopcheck 17m 51s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌ spotbugs 2m 16s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 26s The patch does not generate ASF License warnings.
50m 5s
Reason Tests
FindBugs module:hbase-server
Inconsistent synchronization of org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.services; locked 60% of time Unsynchronized access at FavoredStochasticBalancer.java:60% of time Unsynchronized access at FavoredStochasticBalancer.java:[line 269]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3191
Optional Tests dupname asflicense javac spotbugs hadoopcheck hbaseanti checkstyle compile
uname Linux 0248c5df0965 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 50920ee
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-general-check/output/diff-compile-javac-hbase-balancer.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-balancer.txt
whitespace https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-general-check/output/whitespace-eol.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
Max. process+thread count 96 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 3s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for branch
+1 💚 mvninstall 4m 55s master passed
+1 💚 compile 1m 20s master passed
+1 💚 shadedjars 8m 36s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 52s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 4m 1s the patch passed
+1 💚 compile 1m 21s the patch passed
+1 💚 javac 1m 21s the patch passed
+1 💚 shadedjars 8m 25s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 14s hbase-balancer generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)
_ Other Tests _
+1 💚 unit 0m 25s hbase-balancer in the patch passed.
-1 ❌ unit 247m 5s hbase-server in the patch failed.
281m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux 077595c9f53c 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 50920ee
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/testReport/
Max. process+thread count 3388 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 47s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 5m 20s Maven dependency ordering for branch
+1 💚 mvninstall 6m 41s master passed
+1 💚 compile 1m 50s master passed
+1 💚 shadedjars 9m 45s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 14s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 5m 48s the patch passed
+1 💚 compile 2m 6s the patch passed
+1 💚 javac 2m 6s the patch passed
+1 💚 shadedjars 10m 29s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 17s hbase-balancer generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
_ Other Tests _
+1 💚 unit 0m 30s hbase-balancer in the patch passed.
-1 ❌ unit 252m 10s hbase-server in the patch failed.
301m 21s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux c0a8246cb200 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 50920ee
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/testReport/
Max. process+thread count 3242 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 35s Maven dependency ordering for branch
+1 💚 mvninstall 5m 14s master passed
+1 💚 compile 10m 37s master passed
+1 💚 checkstyle 2m 33s master passed
+1 💚 spotbugs 15m 23s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 4m 39s the patch passed
+1 💚 compile 10m 4s the patch passed
-0 ⚠️ javac 10m 4s root generated 23 new + 1559 unchanged - 1 fixed = 1582 total (was 1560)
-0 ⚠️ checkstyle 2m 33s root: The patch generated 15 new + 163 unchanged - 16 fixed = 178 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 5s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 20m 27s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
-1 ❌ spotbugs 2m 16s hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
-1 ❌ spotbugs 9m 36s root generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
_ Other Tests _
+1 💚 asflicense 0m 42s The patch does not generate ASF License warnings.
95m 19s
Reason Tests
FindBugs module:hbase-server
Inconsistent synchronization of org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.services; locked 60% of time Unsynchronized access at FavoredStochasticBalancer.java:60% of time Unsynchronized access at FavoredStochasticBalancer.java:[line 269]
FindBugs module:root
Inconsistent synchronization of org.apache.hadoop.hbase.master.balancer.FavoredStochasticBalancer.services; locked 60% of time Unsynchronized access at FavoredStochasticBalancer.java:60% of time Unsynchronized access at FavoredStochasticBalancer.java:[line 269]
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3191
Optional Tests dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle
uname Linux ac0c7f235d28 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 96fefce
Default Java AdoptOpenJDK-1.8.0_282-b08
javac https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-general-check/output/diff-compile-javac-root.txt
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-general-check/output/diff-checkstyle-root.txt
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
spotbugs https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-general-check/output/new-spotbugs-root.html
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 2m 30s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 30s Maven dependency ordering for branch
+1 💚 mvninstall 4m 51s master passed
+1 💚 compile 3m 16s master passed
+1 💚 shadedjars 8m 35s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 4s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 47s the patch passed
+1 💚 compile 3m 18s the patch passed
+1 💚 javac 3m 18s the patch passed
+1 💚 shadedjars 8m 33s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 15s hbase-balancer generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
-0 ⚠️ javadoc 3m 5s root generated 5 new + 172 unchanged - 0 fixed = 177 total (was 172)
_ Other Tests _
-1 ❌ unit 266m 8s root in the patch failed.
313m 16s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux 55090af25347 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 96fefce
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/testReport/
Max. process+thread count 2889 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 2s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 38s Maven dependency ordering for branch
+1 💚 mvninstall 4m 3s master passed
+1 💚 compile 2m 46s master passed
+1 💚 shadedjars 8m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 9s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 3m 57s the patch passed
+1 💚 compile 2m 51s the patch passed
+1 💚 javac 2m 51s the patch passed
+1 💚 shadedjars 8m 30s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 14s hbase-balancer generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)
_ Other Tests _
-1 ❌ unit 394m 47s root in the patch failed.
437m 5s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux 7513ddd2f828 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 96fefce
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/testReport/
Max. process+thread count 3120 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 3m 51s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 38s Maven dependency ordering for branch
+1 💚 mvninstall 3m 36s master passed
+1 💚 compile 8m 11s master passed
+1 💚 checkstyle 2m 0s master passed
+1 💚 spotbugs 11m 30s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 19s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 8m 11s the patch passed
+1 💚 javac 8m 11s root generated 0 new + 1559 unchanged - 1 fixed = 1559 total (was 1560)
-0 ⚠️ checkstyle 1m 59s root: The patch generated 3 new + 114 unchanged - 65 fixed = 117 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 3s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 17m 55s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 12m 18s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
83m 19s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3191
Optional Tests dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle
uname Linux 2e59b474004a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-1.8.0_282-b08
checkstyle https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-general-check/output/diff-checkstyle-root.txt
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 20s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for branch
+1 💚 mvninstall 4m 51s master passed
+1 💚 compile 3m 18s master passed
+1 💚 shadedjars 8m 27s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 0s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 4m 46s the patch passed
+1 💚 compile 3m 20s the patch passed
+1 💚 javac 3m 20s the patch passed
+1 💚 shadedjars 8m 30s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-balancer generated 5 new + 2 unchanged - 0 fixed = 7 total (was 2)
-0 ⚠️ javadoc 3m 6s root generated 5 new + 172 unchanged - 0 fixed = 177 total (was 172)
_ Other Tests _
+1 💚 unit 257m 32s root in the patch passed.
308m 28s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux b9dc2e0a6e31 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/testReport/
Max. process+thread count 4414 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 3m 48s master passed
+1 💚 compile 2m 36s master passed
+1 💚 shadedjars 7m 40s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 1s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 31s the patch passed
+1 💚 compile 2m 29s the patch passed
+1 💚 javac 2m 29s the patch passed
+1 💚 shadedjars 7m 42s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 15s hbase-balancer generated 5 new + 1 unchanged - 0 fixed = 6 total (was 1)
_ Other Tests _
-1 ❌ unit 332m 55s root in the patch failed.
371m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux 6502951389f2 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
unit https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/testReport/
Max. process+thread count 4904 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 1s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 32s Maven dependency ordering for branch
+1 💚 mvninstall 3m 47s master passed
+1 💚 compile 8m 11s master passed
+1 💚 checkstyle 1m 58s master passed
+1 💚 spotbugs 11m 41s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 20s Maven dependency ordering for patch
+1 💚 mvninstall 3m 37s the patch passed
+1 💚 compile 8m 9s the patch passed
+1 💚 javac 8m 9s root generated 0 new + 1559 unchanged - 1 fixed = 1559 total (was 1560)
+1 💚 checkstyle 1m 58s root: The patch generated 0 new + 114 unchanged - 65 fixed = 114 total (was 179)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 4s The patch has no ill-formed XML file.
+1 💚 hadoopcheck 17m 42s Patch does not cause any errors with Hadoop 3.1.2 3.2.1 3.3.0.
+1 💚 spotbugs 12m 11s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 41s The patch does not generate ASF License warnings.
79m 42s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #3191
Optional Tests dupname asflicense javac hadoopcheck xml compile spotbugs hbaseanti checkstyle
uname Linux c215b21d5e3d 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-1.8.0_282-b08
Max. process+thread count 141 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/console
versions git=2.17.1 maven=3.6.3 spotbugs=4.2.2
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 12s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 4m 45s master passed
+1 💚 compile 3m 19s master passed
+1 💚 shadedjars 8m 33s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 4m 3s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 18s Maven dependency ordering for patch
+1 💚 mvninstall 4m 42s the patch passed
+1 💚 compile 3m 16s the patch passed
+1 💚 javac 3m 16s the patch passed
+1 💚 shadedjars 8m 35s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 16s hbase-balancer generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
-0 ⚠️ javadoc 3m 4s root generated 2 new + 172 unchanged - 0 fixed = 174 total (was 172)
_ Other Tests _
+1 💚 unit 253m 30s root in the patch passed.
299m 6s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux 2543af9a1b54 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-11.0.10+9
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/testReport/
Max. process+thread count 4424 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 6m 8s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 29s Maven dependency ordering for branch
+1 💚 mvninstall 4m 9s master passed
+1 💚 compile 2m 51s master passed
+1 💚 shadedjars 8m 30s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 3m 5s master passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for patch
+1 💚 mvninstall 3m 58s the patch passed
+1 💚 compile 2m 48s the patch passed
+1 💚 javac 2m 48s the patch passed
+1 💚 shadedjars 8m 24s patch has no errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 14s hbase-balancer generated 2 new + 1 unchanged - 0 fixed = 3 total (was 1)
-0 ⚠️ javadoc 2m 17s root generated 2 new + 54 unchanged - 0 fixed = 56 total (was 54)
_ Other Tests _
+1 💚 unit 403m 36s root in the patch passed.
449m 50s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #3191
Optional Tests javac javadoc unit shadedjars compile
uname Linux f3c318f1a6ab 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 9895b2d
Default Java AdoptOpenJDK-1.8.0_282-b08
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-balancer.txt
javadoc https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-root.txt
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/testReport/
Max. process+thread count 3794 (vs. ulimit of 30000)
modules C: hbase-balancer hbase-server . U: .
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3191/4/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

nyl3532016
nyl3532016 approved these changes Apr 25, 2021
View reviewed changes
Copy link
Contributor

@nyl3532016 nyl3532016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hbase-balancer/src/main/java/org/apache/hadoop/hbase/favored/FavoredNodesPlan.java
@@ -75,7 +75,7 @@ public void updateFavoredNodesMap(RegionInfo region, List<ServerName> servers) {
}

/**
* @return the list of favored region server for this region based on the plan
* Returns the list of favored region server for this region based on the plan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not use javadoc ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generates a error prone warning, where we do not have a javadoc summary for the method but only a return block.

[MissingSummary] A summary fragment is required; consider using the value of the @return block as a summary fragment instead.

The suggestion is to just use the doc for @return as the javadoc summary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get it, Thanks!

@nyl3532016
Copy link
Contributor

FavoredNodeLoadBalancer can be moved out too, or later?

@Apache9
Copy link
Contributor Author

Apache9 commented Apr 25, 2021

FavoredNodeLoadBalancer can be moved out too, or later?

FavoredNodeLoadBalancer is another story, @saintstack suggests that we just purge it from our code base as it never worked well...

Plan to start a discuss thread in the mailing list to see if there are any users of this balancer.

@Apache9 Apache9 merged commit a4d954e into apache:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyl3532016 nyl3532016 nyl3532016 approved these changes

Assignees

@Apache9 Apache9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apache9 @Apache-HBase @nyl3532016