Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-22565 Javadoc Warnings: @see cannot be used in inline documentation #300

Merged
merged 1 commit into from
Jun 13, 2019
Merged

HBASE-22565 Javadoc Warnings: @see cannot be used in inline documentation #300

merged 1 commit into from
Jun 13, 2019

Conversation

murtazahassan123
Copy link
Contributor

HBASE-22565: Fixed Javadoc Warnings: @see cannot be used in inline documentation

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 39 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 24 Maven dependency ordering for branch
+1 mvninstall 267 master passed
+1 compile 79 master passed
+1 checkstyle 102 master passed
+1 shadedjars 278 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 263 master passed
+1 javadoc 53 master passed
_ Patch Compile Tests _
0 mvndep 14 Maven dependency ordering for patch
+1 mvninstall 263 the patch passed
+1 compile 73 the patch passed
+1 javac 73 the patch passed
+1 checkstyle 23 The patch passed checkstyle in hbase-common
+1 checkstyle 75 hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 278 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 791 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 255 the patch passed
+1 javadoc 51 the patch passed
_ Other Tests _
+1 unit 154 hbase-common in the patch passed.
-1 unit 14762 hbase-server in the patch failed.
+1 asflicense 62 The patch does not generate ASF License warnings.
18245
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
hadoop.hbase.client.TestAsyncTableAdminApi
hadoop.hbase.client.TestFromClientSideWithCoprocessor
hadoop.hbase.client.TestFromClientSide3
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/Dockerfile
GITHUB PR #300
JIRA Issue HBASE-22565
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 423737def0ee 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 18 15:02:05 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 934d469
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/testReport/
Max. process+thread count 4556 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet
HorizonNet requested changes Jun 12, 2019
View reviewed changes
Copy link
Contributor

@HorizonNet HorizonNet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a small comment. Otherwise it LGTM. It seems like you're missing a real commit message (it's only the ticket number currently). Would be good if you could change that too.

hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java Show resolved Hide resolved
hbase-server/src/test/java/org/apache/hadoop/hbase/wal/TestWALSplit.java Show resolved Hide resolved
@murtazahassan123 murtazahassan123 changed the title HBASE-22565 HBASE-22565: Javadoc Warnings: @see cannot be used in inline documentation Jun 12, 2019
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 27 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 233 master passed
+1 compile 72 master passed
+1 checkstyle 88 master passed
+1 shadedjars 261 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 231 master passed
+1 javadoc 50 master passed
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 234 the patch passed
+1 compile 70 the patch passed
+1 javac 70 the patch passed
+1 checkstyle 22 The patch passed checkstyle in hbase-common
+1 checkstyle 66 hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 251 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 693 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 220 the patch passed
+1 javadoc 49 the patch passed
_ Other Tests _
+1 unit 161 hbase-common in the patch passed.
+1 unit 8431 hbase-server in the patch passed.
+1 asflicense 61 The patch does not generate ASF License warnings.
11565
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/artifact/out/Dockerfile
GITHUB PR #300
JIRA Issue HBASE-22565
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 60f5fcfdc2d1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / ef44f30
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/testReport/
Max. process+thread count 4972 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet
Copy link
Contributor

@SyedMurtazaHassan You changed the title of the PR, but not the commit message. Could you please do that?

@murtazahassan123 murtazahassan123 changed the title HBASE-22565: Javadoc Warnings: @see cannot be used in inline documentation HBASE-22565 Javadoc Warnings: @see cannot be used in inline documentation Jun 13, 2019
@murtazahassan123
Copy link
Contributor Author

message

@HorizonNet Thanks for the feedback. I have changed the commit message.

@HorizonNet
Copy link
Contributor

@SyedMurtazaHassan Thanks. Will merge it later today.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 167 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 1 The patch does not contain any @author tags.
+1 test4tests 0 The patch appears to include 2 new or modified test files.
_ master Compile Tests _
0 mvndep 31 Maven dependency ordering for branch
+1 mvninstall 296 master passed
+1 compile 96 master passed
+1 checkstyle 119 master passed
+1 shadedjars 329 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 318 master passed
+1 javadoc 65 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 298 the patch passed
+1 compile 92 the patch passed
+1 javac 92 the patch passed
+1 checkstyle 28 The patch passed checkstyle in hbase-common
+1 checkstyle 82 hbase-server: The patch generated 0 new + 23 unchanged - 1 fixed = 23 total (was 24)
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 322 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 939 Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 findbugs 331 the patch passed
+1 javadoc 63 the patch passed
_ Other Tests _
+1 unit 189 hbase-common in the patch passed.
-1 unit 16562 hbase-server in the patch failed.
+1 asflicense 61 The patch does not generate ASF License warnings.
20804
Reason Tests
Failed junit tests hadoop.hbase.client.TestSnapshotTemporaryDirectoryWithRegionReplicas
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/Dockerfile
GITHUB PR #300
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a5d243f18046 4.4.0-143-generic #169-Ubuntu SMP Thu Feb 7 07:56:38 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 863b7b9
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/testReport/
Max. process+thread count 4752 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-300/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@HorizonNet HorizonNet merged commit 9ba7651 into apache:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HorizonNet HorizonNet HorizonNet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@murtazahassan123 @Apache-HBase @HorizonNet