-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-25590 Bulkload replication HFileRefs cannot be cleared in some … #2969
Conversation
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the UT failures which seems related to this change, can we improve comments about these checks?
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java
Show resolved
Hide resolved
...server/src/main/java/org/apache/hadoop/hbase/replication/NamespaceTableCfWALEntryFilter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @wchevreuil for reviewing!
The failed UTs seems to are not related to this PR, it can pass on my own computer, let run it again.
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationPeerConfig.java
Show resolved
Hide resolved
...server/src/main/java/org/apache/hadoop/hbase/replication/NamespaceTableCfWALEntryFilter.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
…cases where set exclude-namespace/exclude-table-cfs
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
…cases where set exclude-namespace/exclude-table-cfs (#2969) Signed-off-by: Wellington Chevreuil <[email protected]>
…cases where set exclude-namespace/exclude-table-cfs (#2969) Signed-off-by: Wellington Chevreuil <[email protected]>
…cases where set exclude-namespace/exclude-table-cfs (#2969) Signed-off-by: Wellington Chevreuil <[email protected]>
…cases where set exclude-namespace/exclude-table-cfs (apache#2969) Signed-off-by: Wellington Chevreuil <[email protected]> (cherry picked from commit 8d0de96)
…cases where set exclude-namespace/exclude-table-cfs