Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24772 Use GetoptLong or OptionParser in hbase-shell #2918

Merged
merged 1 commit into from
Feb 9, 2021
Merged

HBASE-24772 Use GetoptLong or OptionParser in hbase-shell #2918

merged 1 commit into from
Feb 9, 2021

Conversation

laxmanlax
Copy link
Contributor

FIXME: Switch args processing to getopt

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 33s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 59s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 32s the patch passed
-0 ⚠️ rubocop 0m 4s The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 13s The patch does not generate ASF License warnings.
9m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2918
Optional Tests dupname asflicense javac rubocop
uname Linux fa3a0bf02a57 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 79 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 31s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 33s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 9s the patch passed
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 6m 49s hbase-shell in the patch passed.
17m 41s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux d55c3ecc1906 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/testReport/
Max. process+thread count 2194 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 2s master passed
+1 💚 javadoc 0m 16s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 28s the patch passed
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 6m 59s hbase-shell in the patch passed.
19m 51s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux 06073125bbfc 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/testReport/
Max. process+thread count 1542 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/1/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 28s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 51s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 34s the patch passed
-0 ⚠️ rubocop 0m 4s The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
9m 47s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2918
Optional Tests dupname asflicense javac rubocop
uname Linux c574ebd3d2b9 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 18s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 4m 33s master passed
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 24s the patch passed
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 7m 1s hbase-shell in the patch passed.
18m 54s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux 633ed5f5ee9e 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/testReport/
Max. process+thread count 1531 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 40s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 34s master passed
+1 💚 javadoc 0m 28s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 javadoc 0m 13s the patch passed
_ Other Tests _
+1 💚 unit 8m 14s hbase-shell in the patch passed.
22m 46s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux c6dd12f512f5 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/testReport/
Max. process+thread count 1536 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/2/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 26s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 3m 24s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 25s the patch passed
-0 ⚠️ rubocop 0m 5s The patch generated 20 new + 27 unchanged - 5 fixed = 47 total (was 32)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
_ Other Tests _
+1 💚 asflicense 0m 11s The patch does not generate ASF License warnings.
9m 3s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #2918
Optional Tests dupname asflicense javac rubocop
uname Linux 4b9101bf9909 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
rubocop https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-general-check/output/diff-patch-rubocop.txt
Max. process+thread count 78 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions git=2.17.1 maven=3.6.3 rubocop=0.80.0
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 27s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 50s master passed
+1 💚 javadoc 0m 15s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 3m 34s the patch passed
+1 💚 javadoc 0m 14s the patch passed
_ Other Tests _
+1 💚 unit 7m 7s hbase-shell in the patch passed.
16m 39s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux 02733620fada 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-1.8.0_232-b09
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/testReport/
Max. process+thread count 2161 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 44s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 11s master passed
+1 💚 javadoc 0m 14s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 4m 59s the patch passed
+1 💚 javadoc 0m 15s the patch passed
_ Other Tests _
+1 💚 unit 8m 4s hbase-shell in the patch passed.
21m 37s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #2918
Optional Tests javac javadoc unit
uname Linux 2481bdc3d8c0 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / a04ea7e
Default Java AdoptOpenJDK-11.0.6+10
Test Results https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/testReport/
Max. process+thread count 1519 (vs. ulimit of 30000)
modules C: hbase-shell U: hbase-shell
Console output https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2918/3/console
versions git=2.17.1 maven=3.6.3
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@virajjasani
Copy link
Contributor

@bitoffdev would you like to take a look?

saintstack
saintstack approved these changes Feb 8, 2021
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You tried it? Each of the options still works? Thanks.

@laxmanlax
Copy link
Contributor Author

laxmanlax commented Feb 9, 2021 •
edited
Loading

@saintstack I updated the code and tried
> hbase shell on my devbox it works for me

@saintstack saintstack merged commit f09e420 into apache:master Feb 9, 2021
saintstack pushed a commit that referenced this pull request Feb 9, 2021
@laxmanlax @saintstack
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (#2918)
1c64049 
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: stack <[email protected]>
ddupg pushed a commit to ddupg/hbase that referenced this pull request Feb 9, 2021
@laxmanlax
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (apache#2918)
f4a73f3 
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: stack <[email protected]>
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request Feb 24, 2021
@laxmanlax @wchevreuil
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (apache#2918)
7b7744e 
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: stack <[email protected]>
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Aug 22, 2024
@laxmanlax
HBASE-24772 Use GetoptLong or OptionParser in hbase-shell (apache#2918)
0642751 
Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: stack <[email protected]>
(cherry picked from commit 1c64049)
szucsvillo pushed a commit to szucsvillo/hbase that referenced this pull request Sep 9, 2024
@laxmanlax
CDPD-73214: Backport HBASE-24772 Use GetoptLong or OptionParser in hb…
7b0151a 
…ase-shell (apache#2918)

Signed-off-by: Viraj Jasani <[email protected]>
Signed-off-by: stack <[email protected]>
(cherry picked from commit 1c64049)
Change-Id: If3687205dee882ad3371e54e879cefb239a65272
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laxmanlax @Apache-HBase @virajjasani @saintstack