HBASE-22481: Javadoc Warnings reference not found #254

murtazahassan123 · 2019-05-27T10:25:57Z

Fixed the warnings javadoc warnings for MultiTableSnapshotInputFormat.java file.

Apache-HBase · 2019-05-27T11:24:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	31	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+1	mvninstall	238	master passed
+1	compile	23	master passed
+1	checkstyle	15	master passed
+1	shadedjars	250	branch has no errors when building our shaded downstream artifacts.
+1	findbugs	40	master passed
+1	javadoc	16	master passed
		_ Patch Compile Tests _
+1	mvninstall	229	the patch passed
+1	compile	24	the patch passed
+1	javac	24	the patch passed
-1	checkstyle	15	hbase-mapreduce: The patch generated 4 new + 6 unchanged - 0 fixed = 10 total (was 6)
+1	whitespace	0	The patch has no whitespace issues.
+1	shadedjars	253	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	947	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
+1	findbugs	47	the patch passed
+1	javadoc	16	the patch passed
		_ Other Tests _
-1	unit	934	hbase-mapreduce in the patch failed.
+1	asflicense	14	The patch does not generate ASF License warnings.
		3396

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/1/artifact/out/Dockerfile
GITHUB PR	#254
JIRA Issue	HBASE-22481
Optional Tests	dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 04036793b50b 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `73267d9`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/1/artifact/out/diff-checkstyle-hbase-mapreduce.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/1/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/1/testReport/
Max. process+thread count	5509 (vs. ulimit of 10000)
modules	C: hbase-mapreduce U: hbase-mapreduce
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…checkstyle-suppress.xml file

Apache-HBase · 2019-05-27T14:27:14Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	104	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	54	Maven dependency ordering for branch
+1	mvninstall	364	master passed
+1	compile	45	master passed
+1	checkstyle	146	master passed
+1	shadedjars	317	branch has no errors when building our shaded downstream artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	66	master passed
+1	javadoc	35	master passed
		_ Patch Compile Tests _
0	mvndep	17	Maven dependency ordering for patch
+1	mvninstall	302	the patch passed
+1	compile	45	the patch passed
+1	javac	45	the patch passed
+1	checkstyle	141	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	5	The patch has no ill-formed XML file.
+1	shadedjars	308	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	1240	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	68	the patch passed
+1	javadoc	32	the patch passed
		_ Other Tests _
+1	unit	15	hbase-checkstyle in the patch passed.
-1	unit	1886	hbase-mapreduce in the patch failed.
+1	asflicense	28	The patch does not generate ASF License warnings.
		5657

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster
	hadoop.hbase.snapshot.TestMobExportSnapshot

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/2/artifact/out/Dockerfile
GITHUB PR	#254
JIRA Issue	HBASE-22481
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 05a1e6d3d251 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `73267d9`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/2/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/2/testReport/
Max. process+thread count	5278 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/2/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

HorizonNet · 2019-05-27T20:39:58Z

hbase-checkstyle/src/main/resources/hbase/checkstyle-suppressions.xml

@@ -45,4 +45,5 @@
  <suppress checks="IllegalImport" message="org\.apache\.htrace\.core"/>
  <suppress checks="ImportOrder" message="Extra separation in import group before"/>
  <suppress checks="MethodLength" files="DemoClient.java"/>
+  <suppress checks="LineLength" files="MultiTableSnapshotInputFormat.java"/>


Could you please check if it is possible to add the package name to the file suppression?

I have checked and it is possible. Please find the latest commit.

Is it possible to suppress LineLenght check only on the offending lines in the javadoc instead of completely ignoring it in the org.apache.hadoop.hbase.mapred package?

https://stackoverflow.com/a/30070188/3521345

Thanks i will look into it.

I have suppressed LineLength check only on the offending lines in the javadoc using "@SuppressWarnings" annotation. Kindly check the 4th commit for this change.

…d of file

Apache-HBase · 2019-05-28T14:59:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	171	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	19	Maven dependency ordering for branch
+1	mvninstall	260	master passed
+1	compile	35	master passed
+1	checkstyle	135	master passed
+1	shadedjars	265	branch has no errors when building our shaded downstream artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	40	master passed
+1	javadoc	25	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	249	the patch passed
+1	compile	34	the patch passed
+1	javac	34	the patch passed
+1	checkstyle	132	the patch passed
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	2	The patch has no ill-formed XML file.
+1	shadedjars	269	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	982	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.0.3 3.1.2.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	48	the patch passed
+1	javadoc	29	the patch passed
		_ Other Tests _
+1	unit	11	hbase-checkstyle in the patch passed.
+1	unit	1466	hbase-mapreduce in the patch passed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		4538

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/3/artifact/out/Dockerfile
GITHUB PR	#254
JIRA Issue	HBASE-22481
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 69c962728c09 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `9709056`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/3/testReport/
Max. process+thread count	5475 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/3/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

…t check only on the offending lines in the javadoc

Apache-HBase · 2019-06-07T13:35:35Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	24	Docker mode activated.
		_ Prechecks _
+1	hbaseanti	0	Patch does not have any anti-patterns.
+1	@author	0	The patch does not contain any @author tags.
-0	test4tests	0	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
0	mvndep	26	Maven dependency ordering for branch
+1	mvninstall	253	master passed
+1	compile	36	master passed
+1	checkstyle	128	master passed
+1	shadedjars	257	branch has no errors when building our shaded downstream artifacts.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	38	master passed
+1	javadoc	29	master passed
		_ Patch Compile Tests _
0	mvndep	15	Maven dependency ordering for patch
+1	mvninstall	236	the patch passed
+1	compile	35	the patch passed
+1	javac	35	the patch passed
+1	checkstyle	128	root: The patch generated 0 new + 2 unchanged - 4 fixed = 2 total (was 6)
+1	whitespace	0	The patch has no whitespace issues.
+1	xml	5	The patch has no ill-formed XML file.
+1	shadedjars	262	patch has no errors when building our shaded downstream artifacts.
+1	hadoopcheck	720	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
0	findbugs	0	Skipped patched modules with no Java source: hbase-checkstyle
+1	findbugs	47	the patch passed
+1	javadoc	27	the patch passed
		_ Other Tests _
+1	unit	12	hbase-checkstyle in the patch passed.
-1	unit	939	hbase-mapreduce in the patch failed.
+1	asflicense	30	The patch does not generate ASF License warnings.
		3570

Reason	Tests
Failed junit tests	hadoop.hbase.snapshot.TestExportSnapshotNoCluster

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/4/artifact/out/Dockerfile
GITHUB PR	#254
JIRA Issue	HBASE-22481
Optional Tests	dupname asflicense checkstyle javac javadoc unit xml findbugs shadedjars hadoopcheck hbaseanti compile
uname	Linux 57384b6d3df1 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / `302a9ce`
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java	1.8.0_181
findbugs	v3.1.11
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/4/artifact/out/patch-unit-hbase-mapreduce.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/4/testReport/
Max. process+thread count	5542 (vs. ulimit of 10000)
modules	C: hbase-checkstyle hbase-mapreduce U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-254/4/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

petersomogyi

Neat solution! Thanks @SyedMurtazaHassan!

HBASE-22481

3eff922

HBASE-22481 Javadoc Warnings: reference not found, added an entry in …

e802d8c

…checkstyle-suppress.xml file

HorizonNet reviewed May 27, 2019

View reviewed changes

HBASE-22481 Changed suppresions.xml file with check on package instea…

61e1137

…d of file

HBASE-22481: Javadoc Warnings reference not found, suppress LineLengh…

2638f92

…t check only on the offending lines in the javadoc

petersomogyi approved these changes Jun 8, 2019

View reviewed changes

petersomogyi merged commit b32e716 into apache:master Jun 8, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-22481: Javadoc Warnings reference not found #254

HBASE-22481: Javadoc Warnings reference not found #254

murtazahassan123 commented May 27, 2019

Apache-HBase commented May 27, 2019

Apache-HBase commented May 27, 2019

HorizonNet May 27, 2019

murtazahassan123 May 28, 2019

petersomogyi May 29, 2019

murtazahassan123 May 29, 2019

murtazahassan123 Jun 7, 2019 •

edited

Loading

Apache-HBase commented May 28, 2019

Apache-HBase commented Jun 7, 2019

petersomogyi left a comment

HBASE-22481: Javadoc Warnings reference not found #254

HBASE-22481: Javadoc Warnings reference not found #254

Conversation

murtazahassan123 commented May 27, 2019

Apache-HBase commented May 27, 2019

Apache-HBase commented May 27, 2019

HorizonNet May 27, 2019

Choose a reason for hiding this comment

murtazahassan123 May 28, 2019

Choose a reason for hiding this comment

petersomogyi May 29, 2019

Choose a reason for hiding this comment

murtazahassan123 May 29, 2019

Choose a reason for hiding this comment

murtazahassan123 Jun 7, 2019 • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented May 28, 2019

Apache-HBase commented Jun 7, 2019

petersomogyi left a comment

Choose a reason for hiding this comment

murtazahassan123 Jun 7, 2019 •

edited

Loading