HBASE-22429 hbase-vote download step requires URL to end with '/'

[taklwu]

also simplify the download path depth with --cut-dirs 4, and those downloaded files will be under ${HBASE_RC_VERSION} e.g. ${OUTPUT_DIR}/hbase-1.4.10RC0

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
0	reexec	26	Docker mode activated.
		_ Prechecks _
0	shelldocs	0	Shelldocs was not available.
+1	@author	0	The patch does not contain any @author tags.
		_ master Compile Tests _
		_ Patch Compile Tests _
+1	shellcheck	1	There were no new shellcheck issues.
+1	whitespace	0	The patch has no whitespace issues.
		_ Other Tests _
+1	asflicense	13	The patch does not generate ASF License warnings.
		98

Subsystem	Report/Notes
Docker	Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-243/1/artifact/out/Dockerfile
GITHUB PR	#243
Optional Tests	dupname asflicense shellcheck shelldocs
uname	Linux 57bff6812ff6 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool	maven
Personality	/testptch/patchprocess/precommit/personality/provided.sh
git revision	master / bdd2fc6
maven	version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
shellcheck	v0.4.4
Max. process+thread count	46 (vs. ulimit of 10000)
modules	C: . U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-243/1/console
Powered by	Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

[taklwu]

Tested as below

• shellcheck passed

$ shellcheck dev-support/hbase-vote.sh
$ echo $?
0

• RC download worked with and without trailing slash

# with trailing slash
$ bash ~/workspace-tmp/hbase/dev-support/hbase-vote.sh -s https://dist.apache.org/repos/dist/dev/hbase/hbase-1.4.10RC0/

# w/o trailing slash
$ bash ~/workspace-tmp/hbase/dev-support/hbase-vote.sh -s https://dist.apache.org/repos/dist/dev/hbase/2.0.5RC0

# list the current output/working directory only has root level downloaded path with rc version name
$ ls -l 
total 3892
drwxr-xr-x 2 wutaklon amazon    4096 May 16 17:45 2.0.5RC0
...
drwxr-xr-x 3 wutaklon amazon    4096 May 16 17:31 hbase-1.4.10RC0

# double check the downloaded files
$ ls -l hbase-1.4.10RC0
total 122964
-rw-r--r--  1 wutaklon amazon    105011 Apr 30 20:19 compact-check-report.html
drwxr-xr-x 32 wutaklon amazon      4096 May 16 17:32 hbase-1.4.10
-rw-r--r--  1 wutaklon amazon 113352254 May  4 00:59 hbase-1.4.10-bin.tar.gz
-rw-r--r--  1 wutaklon amazon       833 May  4 00:59 hbase-1.4.10-bin.tar.gz.asc
-rw-r--r--  1 wutaklon amazon       219 May  4 00:59 hbase-1.4.10-bin.tar.gz.sha512
-rw-r--r--  1 wutaklon amazon  12424855 Apr 30 20:19 hbase-1.4.10-src.tar.gz
-rw-r--r--  1 wutaklon amazon       833 May  4 00:59 hbase-1.4.10-src.tar.gz.asc
-rw-r--r--  1 wutaklon amazon       219 Apr 30 20:19 hbase-1.4.10-src.tar.gz.sha512
-rw-r--r--  1 wutaklon amazon       769 May  4 00:59 index.html

$ ls -l 2.0.5RC0/
total 142844
-rw-r--r--  1 wutaklon amazon     39288 Mar 25 14:16 api_compare_2.0.5RC0_to_2.0.4.html
-rw-r--r--  1 wutaklon amazon    917476 Feb 28 11:23 CHANGES.md
drwxr-xr-x 38 wutaklon amazon      4096 May 16 17:49 hbase-2.0.5
-rw-r--r--  1 wutaklon amazon 132199267 Feb 28 11:23 hbase-2.0.5-bin.tar.gz
-rw-r--r--  1 wutaklon amazon       819 Feb 28 11:23 hbase-2.0.5-bin.tar.gz.asc
-rw-r--r--  1 wutaklon amazon       216 Feb 28 11:23 hbase-2.0.5-bin.tar.gz.sha512
-rw-r--r--  1 wutaklon amazon  12540654 Feb 28 11:23 hbase-2.0.5-src.tar.gz
-rw-r--r--  1 wutaklon amazon       819 Feb 28 11:23 hbase-2.0.5-src.tar.gz.asc
-rw-r--r--  1 wutaklon amazon       216 Feb 28 11:23 hbase-2.0.5-src.tar.gz.sha512
-rw-r--r--  1 wutaklon amazon       865 Mar 25 14:16 index.html
-rw-r--r--  1 wutaklon amazon    537917 Feb 28 11:23 RELEASENOTES.md
...

[apurtell]

+1