Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22409 update branch-1 ref guide for Hadoop, Java, and HBase version support #239

Merged
merged 27 commits into from
Jun 29, 2019

Conversation

busbey
Copy link
Contributor

@busbey busbey commented May 14, 2019

Will squash into a single commit for merge.

  • Not sure if I should include co-authored-by for authors on the original commits.
  • Locally rendered and checked book
  • I don't think it's worth listing all the individual JIRA keys in the commit message.

@busbey busbey requested a review from apurtell May 14, 2019 07:09
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 1194 Docker failed to build yetus/hbase:61288f8.
Subsystem Report/Notes
GITHUB PR #239
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 docker 191 Docker failed to build yetus/hbase:58089be.
Subsystem Report/Notes
GITHUB PR #239
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1051 Docker mode activated.
_ Prechecks _
0 shelldocs 0 Shelldocs was not available.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
0 mvndep 19 Maven dependency ordering for branch
+1 mvninstall 158 branch-1 passed
0 refguide 183 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 124 branch-1 passed with JDK v1.8.0_212
+1 javadoc 241 branch-1 passed with JDK v1.7.0_222
_ Patch Compile Tests _
0 mvndep 12 Maven dependency ordering for patch
+1 mvninstall 98 the patch passed
+1 shellcheck 0 There were no new shellcheck issues.
+1 whitespace 0 The patch has no whitespace issues.
-1 xml 0 The patch has 2 ill-formed XML file(s).
0 refguide 167 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 125 the patch passed with JDK v1.8.0_212
+1 javadoc 245 the patch passed with JDK v1.7.0_222
_ Other Tests _
-1 unit 2295 root in the patch failed.
+1 asflicense 34 The patch does not generate ASF License warnings.
4876
Reason Tests
XML Parsing Error(s):
hbase-resource-bundle/src/main/resources/supplemental-models.xml
src/main/site/site.xml
Failed junit tests hadoop.hbase.ipc.TestSimpleRpcScheduler
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/artifact/out/Dockerfile
GITHUB PR #239
Optional Tests dupname asflicense shellcheck shelldocs javac javadoc unit xml refguide
uname Linux f1937ad527a0 4.4.0-141-generic #167~14.04.1-Ubuntu SMP Mon Dec 10 13:20:24 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-1 / 58089be
maven version: Apache Maven 3.0.5
Default Java 1.7.0_222
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
shellcheck v0.4.7
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/artifact/out/branch-site/book.html
xml https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/artifact/out/xml.txt
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/artifact/out/patch-site/book.html
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/artifact/out/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/testReport/
Max. process+thread count 701 (vs. ulimit of 10000)
modules C: hbase-resource-bundle . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@petersomogyi petersomogyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice doc update!

src/main/site/site.xml Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 8 #239 does not apply to branch-1. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.
Subsystem Report/Notes
GITHUB PR #239
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/4/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@apurtell apurtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I spot checked a few things and noted where there were minor differences

src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Outdated Show resolved Hide resolved
src/main/asciidoc/_chapters/ops_mgt.adoc Show resolved Hide resolved
@busbey
Copy link
Contributor Author

busbey commented Jun 13, 2019

okay let me get this rebased and these specific comments addressed rather than try to handle them via additional cherry-picks.

busbey and others added 21 commits June 12, 2019 21:44
(cherry picked from commit 51b606c)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
(cherry picked from commit 348a11a)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
(cherry picked from commit e54cb8a)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
(cherry picked from commit 5e2c2e1)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
… vs "not supported"

(cherry picked from commit 9cd4871)
…n our hadoop support matrix

(cherry picked from commit 9a9e3df)
Signed-off-by: Michael Stack <[email protected]>
(cherry picked from commit b290d14)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
Signed-off-by: Enis Soztutar <[email protected]>
Signed-off-by: Michael Stack <[email protected]>
(cherry picked from commit a8e6f33)

 Conflicts:
	src/main/asciidoc/_chapters/community.adoc
	src/main/asciidoc/_chapters/configuration.adoc
	src/main/asciidoc/_chapters/cp.adoc
	src/main/asciidoc/_chapters/developer.adoc
	src/main/site/site.xml
(cherry picked from commit b12d071)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
(cherry picked from commit 2a5e5e9)

 Conflicts:
	dev-support/hbase-personality.sh
	hbase-resource-bundle/src/main/resources/supplemental-models.xml
	pom.xml
	src/main/asciidoc/_chapters/configuration.adoc
Signed-off-by: Ted Yu <[email protected]>
(cherry picked from commit 7889df3)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
…nd 2.9.0.

Signed-off-by: Mike Drob <[email protected]>
(cherry picked from commit 65bd088)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
…ote about using LTS releases.

* Make the #java anchor point at a section instead of directly at a table
* Add a note to the intro of that section about LTS JDKs
* Add columns for JDK9 and JDK10 that say unsupported and point to HBASE-20264

Signed-off-by: Zach York <[email protected]>
(cherry picked from commit 9ea1a7d)
(cherry picked from commit 6a5c14b)

 Conflicts:
	src/main/asciidoc/_chapters/architecture.adoc
	src/main/asciidoc/_chapters/backup_restore.adoc
	src/main/asciidoc/_chapters/configuration.adoc
	src/main/asciidoc/_chapters/getting_started.adoc
	src/main/asciidoc/_chapters/troubleshooting.adoc
	src/main/asciidoc/_chapters/upgrading.adoc
Minor edit on hadoop section. Mark 2.8.3 as supported and 2.8.2 as NT.

(cherry picked from commit 1b2e803)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
…doop 3.1.0

Amending-Author: Sean Busbey <[email protected]>

Signed-off-by: zhangduo <[email protected]>
(cherry picked from commit 79e960f)
Amending-Author: Peter Somogyi <[email protected]>
(cherry picked from commit 7d6ce35)
(cherry picked from commit 9b957d8)
Signed-off-by: Sean Busbey <[email protected]>
(cherry picked from commit 2b5b190)
(cherry picked from commit aa31dbe)

 Conflicts:
	src/main/asciidoc/_chapters/configuration.adoc
Signed-off-by: Peter Somogyi <[email protected]>
(cherry picked from commit 9743b3c)
(cherry picked from commit fb7a020)
Signed-off-by: Andrew Purtell <[email protected]>
(cherry picked from commit feee97f)
(cherry picked from commit 6733025)
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 1286 Docker mode activated.
_ Prechecks _
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-1 Compile Tests _
0 mvndep 14 Maven dependency ordering for branch
+1 mvninstall 118 branch-1 passed
0 refguide 171 branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 123 branch-1 passed with JDK v1.8.0_212
+1 javadoc 233 branch-1 passed with JDK v1.7.0_222
_ Patch Compile Tests _
0 mvndep 13 Maven dependency ordering for patch
+1 mvninstall 98 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
-1 xml 0 The patch has 2 ill-formed XML file(s).
0 refguide 159 patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 javadoc 119 the patch passed with JDK v1.8.0_212
+1 javadoc 229 the patch passed with JDK v1.7.0_222
_ Other Tests _
-1 unit 10457 root in the patch failed.
+1 asflicense 43 The patch does not generate ASF License warnings.
13134
Reason Tests
XML Parsing Error(s):
hbase-resource-bundle/src/main/resources/supplemental-models.xml
src/main/site/site.xml
Failed junit tests hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles
hadoop.hbase.master.normalizer.TestSimpleRegionNormalizerOnCluster
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/artifact/out/Dockerfile
GITHUB PR #239
Optional Tests dupname asflicense javac javadoc unit xml refguide
uname Linux f203b010f6a0 4.4.0-137-generic #163-Ubuntu SMP Mon Sep 24 13:14:43 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision branch-1 / 60cea9e
maven version: Apache Maven 3.0.5
Default Java 1.7.0_222
Multi-JDK versions /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_212 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_222
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/artifact/out/branch-site/book.html
xml https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/artifact/out/xml.txt
refguide https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/artifact/out/patch-site/book.html
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/artifact/out/patch-unit-root.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/testReport/
Max. process+thread count 4234 (vs. ulimit of 10000)
modules C: hbase-resource-bundle . U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-239/5/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@petersomogyi
Copy link
Contributor

@busbey Can we merge this change?

@busbey
Copy link
Contributor Author

busbey commented Jun 28, 2019

yep! I think I was just waiting to get the sign-offs in place? I'll push this evening.

@petersomogyi petersomogyi merged commit 7828d6a into apache:branch-1 Jun 29, 2019
@busbey busbey deleted the HBASE-22409 branch June 30, 2019 01:08
@busbey
Copy link
Contributor Author

busbey commented Jun 30, 2019

that works too. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants