HBASE-24918 Make RegionInfo#UNDEFINED IA.Private #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch is same as last PR attached to HBASE-24896 only no claims it fixes HBASE-24896....It is deprecation, annotation, and moving an inner-class out to be standalone only. |
bharathv
reviewed
Aug 20, 2020
| */ | ||
| @Deprecated | ||
| @InterfaceAudience.Private | ||
| // Not using RegionInfoBuilder intentionally to avoid a static loading deadlock: HBASE-24627 |
There was a problem hiding this comment.
I think this statement can be omitted since this is being handled separately in the parent task.
| @Deprecated | ||
| @InterfaceAudience.Private | ||
| // Not using RegionInfoBuilder intentionally to avoid a static loading deadlock: HBASE-24627 | ||
| RegionInfo UNDEFINED = new MutableRegionInfo(0, TableName.valueOf("__UNDEFINED__"), |
There was a problem hiding this comment.
Switch back to RegionInfoBuilder? (same below?)
saintstack
force-pushed
the
HBASE-24918
branch
from
00a629f to
47add12
Compare
|
Push addresses @bharathv review |
|
@saintstack Looks like the push didn't address the comments or is it just me? |
Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a stanadlone task; a nice-to-have.
saintstack
force-pushed
the
HBASE-24918
branch
from
47add12 to
0c5412f
Compare
|
@bharathv my fault... loaded but not committed. Thanks. |
bharathv
approved these changes
Aug 20, 2020
Apache9
approved these changes
Aug 21, 2020
saintstack
added a commit
that referenced
this pull request
Aug 21, 2020
Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a stanadlone task; a nice-to-have. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
saintstack
added a commit
that referenced
this pull request
Aug 21, 2020
Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a stanadlone task; a nice-to-have. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
Mark RegionInfo#UNDEFINED IA.Private and deprecated; it is for internal use only and likely to be removed in hbase4. Move MutableRegionInfo out of RegionInfoBuilder and have it as a stanadlone task; a nice-to-have. Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Bharath Vissapragada <[email protected]> Signed-off-by: Duo Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark RegionInfo#UNDEFINED IA.Private and deprecated;
it is for internal use only and likely to be removed in hbase4.
Move MutableRegionInfo out of RegionInfoBuilder and have it as a
stanadlone task; a nice-to-have.