Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider #2272

Closed
wants to merge 6 commits into from
Closed

HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.currentTimeMillis() in CurrentHourProvider #2272

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cb4c428
HBASE-24898 Use EnvironmentEdge.currentTime() instead of System.curre…
bsglz Aug 19, 2020
c458312
fix review issue
bsglz Aug 20, 2020
c106fd7
fix ut failure
bsglz Aug 20, 2020
bc4fb62
fix ut failure
bsglz Aug 21, 2020
d6e7377
fix review issue
bsglz Aug 21, 2020
5fab718
fix checkstyle warning
bsglz Aug 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...r/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CurrentHourProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import java.util.Calendar;
import java.util.GregorianCalendar;

import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
import org.apache.yetus.audience.InterfaceAudience;

@InterfaceAudience.Private
Expand Down Expand Up @@ -54,7 +55,7 @@ private static void moveToNextHour(Calendar calendar) {

public static int getCurrentHour() {
Tick tick = CurrentHourProvider.tick;
if(System.currentTimeMillis() < tick.expirationTimeInMillis) {
if (EnvironmentEdgeManager.currentTime() < tick.expirationTimeInMillis) {
return tick.currentHour;
}

Expand Down