-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24894 [Flakey Test] TestStochasticLoadBalancer.testMoveCostMult… #2270
Conversation
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will be valid only after #2272 right?
Yeah. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
@virajjasani The pr #2272 merged yet, can you help to review this one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
The failure seems unrelated to this pr, since it only changed unit test class. |
I think this pr is not need to update, since even consider the daylight saving time in some timezone, the time we inject will be provide a hour which always in off peak as we expect. |
@bsglz This was still failing for PDT timezone right? I didn't get your concern. You are saying we don't need this patch at all? |
No, it will success no matter the timezone, i mean it could be merged with no more change. |
Got it, let me just trigger build one last time. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
The failure on jdk11 seems strange, i think it is unrelated to this pr. |
…iplier Closes #2270 Signed-off-by: Viraj Jasani <[email protected]>
…iplier Closes #2270 Signed-off-by: Viraj Jasani <[email protected]>
…iplier Closes #2270 Signed-off-by: Viraj Jasani <[email protected]>
…iplier Closes apache#2270 Signed-off-by: Viraj Jasani <[email protected]>
…iplier