HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. #2208

nyl3532016 · 2020-08-06T10:20:59Z

Since PoolType.Reusable is no longer used, It is better removed, otherwise will confuse people

Apache-HBase · 2020-08-06T10:54:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	3m 50s	master passed
+1 💚	compile	0m 26s	master passed
+1 💚	shadedjars	5m 53s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 26s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 37s	the patch passed
+1 💚	compile	0m 26s	the patch passed
+1 💚	javac	0m 26s	the patch passed
+1 💚	shadedjars	5m 49s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 23s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 6s	hbase-client in the patch passed.
		23m 39s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2208
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux e0a1b208a962 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
Default Java	1.8.0_232
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/testReport/
Max. process+thread count	339 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-06T10:58:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 10s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	0m 30s	master passed
+1 💚	shadedjars	6m 20s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 28s	hbase-client in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 39s	the patch passed
+1 💚	compile	0m 29s	the patch passed
+1 💚	javac	0m 29s	the patch passed
+1 💚	shadedjars	6m 25s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 25s	hbase-client in the patch failed.
		_ Other Tests _
+1 💚	unit	1m 21s	hbase-client in the patch passed.
		27m 37s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2208
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f46cb3701513 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
Default Java	2020-01-14
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt
javadoc	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt
Test Results	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/testReport/
Max. process+thread count	204 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-08-06T11:00:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 26s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 46s	master passed
+1 💚	checkstyle	0m 26s	master passed
+1 💚	spotbugs	1m 0s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 28s	the patch passed
-0 ⚠️	checkstyle	0m 26s	hbase-client: The patch generated 1 new + 6 unchanged - 2 fixed = 7 total (was 8)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 30s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	1m 12s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 13s	The patch does not generate ASF License warnings.
		29m 57s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2208
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux f6f6d2e28d30 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `c39cad2`
checkstyle	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-client.txt
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-client U: hbase-client
Console output	https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-2208/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…#2208)" incorrect commit message and author This reverts commit c645cb5.

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

busbey · 2020-08-12T03:14:00Z

the above two commits corrected the commit metadata to include a jira id at the start of the subject and to put in the original author in addition to the co-authored-by.

nyl3532016 · 2020-08-12T03:39:27Z

Thanks @busbey for amend

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

…ype. (apache#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

…ype. (apache#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]> (cherry picked from commit 9e75797) Change-Id: Ibc92c0b755c8cc9baaa51af6de6d2deb2cc29fd6

BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.

593040b

nyl3532016 changed the title ~~BackPort HBASE-11554 Remove Reusable poolmap Rpc client type.~~ HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. Aug 6, 2020

saintstack merged commit c645cb5 into apache:master Aug 6, 2020

asfgit pushed a commit that referenced this pull request Aug 12, 2020

Revert "BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. (…

b9c415a

…#2208)" incorrect commit message and author This reverts commit c645cb5.

asfgit pushed a commit that referenced this pull request Aug 12, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client t…

8646ac1

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

nyl3532016 mentioned this pull request Aug 13, 2020

HBASE-24872 refactor valueOf PoolType #2250

Merged

asfgit pushed a commit that referenced this pull request Nov 26, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client t…

35a2875

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Nov 26, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client t…

b2eb13f

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

asfgit pushed a commit that referenced this pull request Nov 26, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client t…

9e75797

…ype. (#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

ramkrish86 pushed a commit to ramkrish86/hbase that referenced this pull request Dec 8, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client t…

c28a7ff

…ype. (apache#2208) Co-authored-by: niuyulin <[email protected]> Signed-off-by: stack <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. #2208

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. #2208

nyl3532016 commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

busbey commented Aug 12, 2020

nyl3532016 commented Aug 12, 2020

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. #2208

HBASE-24827 BackPort HBASE-11554 Remove Reusable poolmap Rpc client type. #2208

Conversation

nyl3532016 commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

Apache-HBase commented Aug 6, 2020

busbey commented Aug 12, 2020

nyl3532016 commented Aug 12, 2020