-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-24803 Unify hbase-shell ::Shell::Commands::Command#help behavior #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update all hbase-shell commands to return help text implicitly - Add hbase-shell test to ensure all help methods return unindented text - Set the outermost indentation to zero for the help text of all hbase-shell commands by using the squiggly heredoc added in Ruby 2.3.0. - Document return value of hbck_chore_run and add usage examples to truncate commands - Update docs to reflect current return value of list command
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
saintstack
pushed a commit
that referenced
this pull request
Jul 31, 2020
#2178) - Update all hbase-shell commands to return help text implicitly - Add hbase-shell test to ensure all help methods return unindented text - Set the outermost indentation to zero for the help text of all hbase-shell commands by using the squiggly heredoc added in Ruby 2.3.0. - Document return value of hbck_chore_run and add usage examples to truncate commands - Update docs to reflect current return value of list command Signed-off-by: stack <[email protected]>
clarax
pushed a commit
to clarax/hbase
that referenced
this pull request
Nov 15, 2020
apache#2178) - Update all hbase-shell commands to return help text implicitly - Add hbase-shell test to ensure all help methods return unindented text - Set the outermost indentation to zero for the help text of all hbase-shell commands by using the squiggly heredoc added in Ruby 2.3.0. - Document return value of hbck_chore_run and add usage examples to truncate commands - Update docs to reflect current return value of list command Signed-off-by: stack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.apache.org/jira/browse/HBASE-24803
Changelog
commands by using the squiggly heredoc added in Ruby 2.3.0.