HBASE-21714 Deprecated isTableAvailableWithSplit method in thrift module #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
Apache9
requested changes
May 5, 2019
| @@ -940,6 +940,8 @@ service THBaseService { | |||
| * region gets splitted, the api may return false. | |||
| * | |||
| * @return true if table is available, false if not | |||
| * | |||
| * @deprecated since version 2.1.4 | |||
There was a problem hiding this comment.
Should be 2.3.0 or 2.2.0? And please add comment to say when will we remove it, I would like to remove it in 3.0.0, to align with the Table interface. So here we need to tell user that we will remove it in 3.0.0 for aligning with the Table interface, as in general, it should be removed in 4.0.0.
|
@nyl3532016 You can reuse the old PR actually. not a big problem anyway. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
this checkstyle -1 is a problem? |
|
@nyl3532016 Yes, would be good to get this fixed before committing it. It should be an easy one. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
Apache9
requested changes
May 6, 2019
| @@ -940,6 +940,9 @@ service THBaseService { | |||
| * region gets splitted, the api may return false. | |||
| * | |||
| * @return true if table is available, false if not | |||
| * | |||
| * @deprecated Since 2.0.0. Will be removed in 3.0.0. | |||
There was a problem hiding this comment.
It should be 2.2.0? I mean you need to say that the same method in Table interface has been deprecated since 2.0.0, so we will remove it in 3.0.0 release.
There was a problem hiding this comment.
ok ,I have amended
|
🎊 +1 overall
This message was automatically generated. |
Apache9
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.