Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-24757 : ReplicationSink should limit row count in batch mutation based on hbase.rpc.rows.warning.threshold #2139

Merged
merged 2 commits into from
Jul 27, 2020

Conversation

virajjasani
Copy link
Contributor

Closes #2127

Signed-off-by: stack [email protected]

…n based on hbase.rpc.rows.warning.threshold

Closes apache#2127

Signed-off-by: stack <[email protected]>
@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 44s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 17s Maven dependency ordering for branch
+1 💚 mvninstall 6m 43s branch-2.2 passed
+1 💚 compile 1m 38s branch-2.2 passed
+1 💚 checkstyle 2m 18s branch-2.2 passed
+1 💚 shadedjars 5m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 1m 4s branch-2.2 passed
+0 🆗 spotbugs 4m 20s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 21s branch-2.2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for patch
+1 💚 mvninstall 6m 16s the patch passed
+1 💚 compile 1m 23s the patch passed
+1 💚 javac 1m 23s the patch passed
-1 ❌ checkstyle 1m 24s hbase-server: The patch generated 2 new + 116 unchanged - 4 fixed = 118 total (was 120)
+1 💚 whitespace 0m 1s The patch has no whitespace issues.
+1 💚 shadedjars 4m 15s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 26m 17s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 57s the patch passed
+1 💚 findbugs 4m 20s the patch passed
_ Other Tests _
+1 💚 unit 3m 8s hbase-common in the patch passed.
-1 ❌ unit 179m 10s hbase-server in the patch failed.
+1 💚 asflicense 1m 2s The patch does not generate ASF License warnings.
259m 13s
Reason Tests
Failed junit tests hadoop.hbase.replication.regionserver.TestRegionReplicaReplicationEndpoint
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/Dockerfile
GITHUB PR #2139
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux fc53b5f6065c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revision branch-2.2 / 8dec49a
Default Java 1.8.0_181
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/diff-checkstyle-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/testReport/
Max. process+thread count 4335 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/1/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 4m 16s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 5m 33s branch-2.2 passed
+1 💚 compile 1m 24s branch-2.2 passed
+1 💚 checkstyle 2m 0s branch-2.2 passed
+1 💚 shadedjars 4m 23s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 58s branch-2.2 passed
+0 🆗 spotbugs 3m 32s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 21s branch-2.2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 5m 16s the patch passed
+1 💚 compile 1m 24s the patch passed
+1 💚 javac 1m 24s the patch passed
+1 💚 checkstyle 0m 27s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 1m 32s hbase-server: The patch generated 0 new + 116 unchanged - 4 fixed = 116 total (was 120)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 25s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 3s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 56s the patch passed
+1 💚 findbugs 4m 39s the patch passed
_ Other Tests _
+1 💚 unit 2m 59s hbase-common in the patch passed.
-1 ❌ unit 289m 50s hbase-server in the patch failed.
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
370m 39s
Reason Tests
Failed junit tests hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleAsyncWAL
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/artifact/out/Dockerfile
GITHUB PR #2139
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 25cc8217dcc1 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revision branch-2.2 / 8dec49a
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/testReport/
Max. process+thread count 4940 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/2/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 19s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ branch-2.2 Compile Tests _
+0 🆗 mvndep 0m 16s Maven dependency ordering for branch
+1 💚 mvninstall 5m 32s branch-2.2 passed
+1 💚 compile 1m 20s branch-2.2 passed
+1 💚 checkstyle 2m 3s branch-2.2 passed
+1 💚 shadedjars 4m 24s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 57s branch-2.2 passed
+0 🆗 spotbugs 3m 31s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 4m 19s branch-2.2 passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 14s Maven dependency ordering for patch
+1 💚 mvninstall 5m 10s the patch passed
+1 💚 compile 1m 20s the patch passed
+1 💚 javac 1m 20s the patch passed
+1 💚 checkstyle 0m 26s The patch passed checkstyle in hbase-common
+1 💚 checkstyle 1m 33s hbase-server: The patch generated 0 new + 116 unchanged - 4 fixed = 116 total (was 120)
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 4m 21s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 28m 5s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 2.10.0 or 3.1.2 3.2.1.
+1 💚 javadoc 0m 57s the patch passed
+1 💚 findbugs 4m 31s the patch passed
_ Other Tests _
+1 💚 unit 3m 0s hbase-common in the patch passed.
-1 ❌ unit 295m 27s hbase-server in the patch failed.
+1 💚 asflicense 0m 55s The patch does not generate ASF License warnings.
372m 50s
Reason Tests
Failed junit tests hadoop.hbase.replication.multiwal.TestReplicationSyncUpToolWithMultipleWAL
hadoop.hbase.client.TestAdmin1
hadoop.hbase.master.TestAssignmentManagerMetrics
Subsystem Report/Notes
Docker Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/artifact/out/Dockerfile
GITHUB PR #2139
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 291e511ef7b5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-2139/out/precommit/personality/provided.sh
git revision branch-2.2 / 8dec49a
Default Java 1.8.0_181
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/artifact/out/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/testReport/
Max. process+thread count 5035 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2139/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@virajjasani virajjasani merged commit 603d2b6 into apache:branch-2.2 Jul 27, 2020
@virajjasani virajjasani deleted the HBASE-24757-branch-2.2 branch July 27, 2020 19:41
wchevreuil pushed a commit to wchevreuil/hbase that referenced this pull request May 24, 2021
…n based on hbase.rpc.rows.warning.threshold (apache#2139)

Closes apache#2127

Signed-off-by: stack <[email protected]>
(cherry picked from commit 603d2b6)

Change-Id: I27416e5ee65bc2cbcb776e7f83487cb2c06e147a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants