HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… #2079

wchevreuil · 2020-07-17T17:17:03Z

…ith an uncaught exception

virajjasani

+1

virajjasani · 2020-07-17T17:25:21Z

hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java

              new HBaseSaslRpcServer(provider, rpcServer.saslProps, rpcServer.secretManager);
+          } catch (Exception e){


nit: this can be IOException? Exception is also fine though since the purpose is to log any uncaught exceptions.

Yeah, the goal here is to catch any uncaught exception that may be thrown by faulty custom providers.

Apache-HBase · 2020-07-17T17:56:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 34s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	checkstyle	1m 13s	master passed
+1 💚	spotbugs	2m 7s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	checkstyle	1m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 19s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 14s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 14s	The patch does not generate ASF License warnings.
		36m 30s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2079
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux 665b2603f67a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1781185`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-17T19:57:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 25s	master passed
+1 💚	compile	1m 4s	master passed
+1 💚	shadedjars	5m 48s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 5s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	5m 43s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	130m 56s	hbase-server in the patch passed.
		157m 13s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2079
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 15f5f50b0eec 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1781185`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/testReport/
Max. process+thread count	4464 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-17T21:10:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 15s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 3s	master passed
+1 💚	compile	0m 56s	master passed
+1 💚	shadedjars	6m 6s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 43s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	6m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	203m 49s	hbase-server in the patch passed.
		229m 58s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2079
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 4a771f0178f3 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `1781185`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/testReport/
Max. process+thread count	3652 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2079/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…ith an uncaught exception (#2079) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Josh Elser <[email protected]> (cherry picked from commit bd42c75)

…ith an uncaught exception (apache#2079) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Josh Elser <[email protected]> (cherry picked from commit bd42c75)

…ith an uncaught exception (apache#2079) Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Josh Elser <[email protected]> Author: Wellington Chevreuil Reason: Supportability Ref: CDPD-15248 Change-Id: I78a1c87bea2c6e6a1204a46e0bf6676d5b7f896e

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w…

a8b2deb

…ith an uncaught exception

wchevreuil requested review from joshelser and virajjasani July 17, 2020 17:17

virajjasani approved these changes Jul 17, 2020

View reviewed changes

joshelser approved these changes Jul 17, 2020

View reviewed changes

wchevreuil merged commit bd42c75 into apache:master Jul 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… #2079

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… #2079

wchevreuil commented Jul 17, 2020

virajjasani left a comment

virajjasani Jul 17, 2020

wchevreuil Jul 17, 2020

Apache-HBase commented Jul 17, 2020

Apache-HBase commented Jul 17, 2020

Apache-HBase commented Jul 17, 2020

		new HBaseSaslRpcServer(provider, rpcServer.saslProps, rpcServer.secretManager);
		} catch (Exception e){

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… #2079

HBASE-24747 Log an ERROR if HBaseSaslRpcServer initialisation fails w… #2079

Conversation

wchevreuil commented Jul 17, 2020

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Jul 17, 2020

Choose a reason for hiding this comment

wchevreuil Jul 17, 2020

Choose a reason for hiding this comment

Apache-HBase commented Jul 17, 2020

Apache-HBase commented Jul 17, 2020

Apache-HBase commented Jul 17, 2020