Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBASE-22340 Corrupt KeyValue is silently ignored #207

Merged
merged 2 commits into from
May 2, 2019

Conversation

petersomogyi
Copy link
Contributor

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 21 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 26 Maven dependency ordering for branch
+1 mvninstall 252 master passed
+1 compile 73 master passed
+1 checkstyle 93 master passed
+1 shadedjars 259 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 257 master passed
+1 javadoc 53 master passed
_ Patch Compile Tests _
0 mvndep 16 Maven dependency ordering for patch
+1 mvninstall 243 the patch passed
+1 compile 74 the patch passed
+1 javac 74 the patch passed
-1 checkstyle 24 hbase-common: The patch generated 2 new + 27 unchanged - 0 fixed = 29 total (was 27)
+1 whitespace 1 The patch has no whitespace issues.
+1 shadedjars 261 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 494 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 235 the patch passed
+1 javadoc 52 the patch passed
_ Other Tests _
+1 unit 169 hbase-common in the patch passed.
+1 unit 8315 hbase-server in the patch passed.
+1 asflicense 49 The patch does not generate ASF License warnings.
11133
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/artifact/out/Dockerfile
GITHUB PR #207
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux 3d2bb020076a 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / 3f40df8
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
checkstyle https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/artifact/out/diff-checkstyle-hbase-common.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/testReport/
Max. process+thread count 4531 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
0 reexec 22 Docker mode activated.
_ Prechecks _
+1 hbaseanti 0 Patch does not have any anti-patterns.
+1 @author 0 The patch does not contain any @author tags.
-0 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
0 mvndep 15 Maven dependency ordering for branch
+1 mvninstall 246 master passed
+1 compile 72 master passed
+1 checkstyle 91 master passed
+1 shadedjars 260 branch has no errors when building our shaded downstream artifacts.
+1 findbugs 251 master passed
+1 javadoc 51 master passed
_ Patch Compile Tests _
0 mvndep 15 Maven dependency ordering for patch
+1 mvninstall 232 the patch passed
+1 compile 72 the patch passed
+1 javac 72 the patch passed
+1 checkstyle 92 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedjars 261 patch has no errors when building our shaded downstream artifacts.
+1 hadoopcheck 498 Patch does not cause any errors with Hadoop 2.7.4 or 3.0.0.
+1 findbugs 275 the patch passed
+1 javadoc 53 the patch passed
_ Other Tests _
+1 unit 165 hbase-common in the patch passed.
+1 unit 8163 hbase-server in the patch passed.
+1 asflicense 57 The patch does not generate ASF License warnings.
10985
Subsystem Report/Notes
Docker Client=17.05.0-ce Server=17.05.0-ce base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/artifact/out/Dockerfile
GITHUB PR #207
Optional Tests dupname asflicense javac javadoc unit findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux a662ab787faa 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 GNU/Linux
Build tool maven
Personality /testptch/patchprocess/precommit/personality/provided.sh
git revision master / e44fe49
maven version: Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-17T18:33:14Z)
Default Java 1.8.0_181
findbugs v3.1.11
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/testReport/
Max. process+thread count 5178 (vs. ulimit of 10000)
modules C: hbase-common hbase-server U: .
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-207/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@apurtell apurtell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@petersomogyi petersomogyi merged commit 94122f6 into apache:master May 2, 2019
@petersomogyi petersomogyi deleted the HBASE-22340 branch September 23, 2019 07:17
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
symat pushed a commit to symat/hbase that referenced this pull request Feb 17, 2021
(cherry picked from commit f60a64c)

Change-Id: I6b32dc2eb91f4419b40efe79be923c2fa25b88b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants