HBASE-24675: On Master restart all servers are assigned to default rs… #2053

arshadmohammad · 2020-07-12T21:34:52Z

…group.

Apache-HBase · 2020-07-12T22:12:19Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 28s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	3m 45s	master passed
+1 💚	checkstyle	1m 5s	master passed
+1 💚	spotbugs	1m 57s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 19s	the patch passed
+1 💚	checkstyle	1m 4s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	11m 5s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 8s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		32m 13s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux f663db2b2a2b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `724f047`
Max. process+thread count	94 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-13T01:53:57Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 2s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 4s	master passed
+1 💚	compile	1m 16s	master passed
+1 💚	shadedjars	6m 35s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 45s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 43s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	shadedjars	6m 44s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 49s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	223m 13s	hbase-server in the patch passed.
		253m 48s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 110d15f6900c 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `724f047`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/testReport/
Max. process+thread count	3113 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-13T02:03:35Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 21s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	6m 13s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 40s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 0s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	6m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	the patch passed
		_ Other Tests _
+1 💚	unit	235m 55s	hbase-server in the patch passed.
		263m 27s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 7cbed90306b9 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `724f047`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/testReport/
Max. process+thread count	3639 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/1/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

virajjasani · 2020-07-13T06:30:03Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

@@ -591,7 +591,7 @@ private synchronized void refresh(boolean forceOnline) throws IOException {

    // This is added to the last of the list so it overwrites the 'default' rsgroup loaded
    // from region group table or zk
-    groupList.add(new RSGroupInfo(RSGroupInfo.DEFAULT_GROUP, getDefaultServers()));
+    groupList.add(new RSGroupInfo(RSGroupInfo.DEFAULT_GROUP, getDefaultServers(groupList)));


refresh fetching info from rsgroup table / ZK makes sense.

So the issue is by this time, the in memory state 'holder' not created in the HM restart case. This is a very bad bug.. This should go into all active branches no?

branch-1 fix was pending, raised PR #2102

virajjasani · 2020-07-13T06:32:09Z

FYI @Apache9
you will have better insights.

…group.

Apache-HBase · 2020-07-13T16:43:14Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	4m 6s	master passed
+1 💚	checkstyle	1m 15s	master passed
+1 💚	spotbugs	2m 8s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 47s	the patch passed
+1 💚	checkstyle	1m 12s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	12m 13s	Patch does not cause any errors with Hadoop 3.1.2 3.2.1.
+1 💚	spotbugs	2m 16s	the patch passed
		_ Other Tests _
+1 💚	asflicense	0m 12s	The patch does not generate ASF License warnings.
		35m 50s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname	Linux be3c1019c8c4 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Max. process+thread count	84 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-13T19:55:38Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 9s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 5s	master passed
+1 💚	compile	0m 57s	master passed
+1 💚	shadedjars	6m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 38s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	3m 42s	the patch passed
+1 💚	compile	0m 58s	the patch passed
+1 💚	javac	0m 58s	the patch passed
+1 💚	shadedjars	6m 4s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	202m 13s	hbase-server in the patch passed.
		228m 13s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux a41b40ea585f 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/testReport/
Max. process+thread count	3764 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-07-13T20:19:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	4m 43s	master passed
+1 💚	compile	1m 13s	master passed
+1 💚	shadedjars	6m 26s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 43s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	4m 32s	the patch passed
+1 💚	compile	1m 10s	the patch passed
+1 💚	javac	1m 10s	the patch passed
+1 💚	shadedjars	6m 23s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 40s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	215m 51s	hbase-server in the patch passed.
		244m 52s

Subsystem	Report/Notes
Docker	Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#2053
JIRA Issue	HBASE-24675
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux f557074d66fc 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `3bd5421`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/testReport/
Max. process+thread count	3244 (vs. ulimit of 12500)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2053/2/console
versions	git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

…group Closes #2053 Signed-off-by: Viraj Jasani <[email protected]>

anoopsjohn · 2020-07-20T07:49:33Z

hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java

+    return getDefaultServers(listRSGroups()/* get from rsGroupMap */);
+  }
+
+  // Called by ServerEventsListenerThread. Presume it has lock on this manager when it runs.


Also pls leave this comment. The ServerEventsListenerThread calls the above method only.

right, comment is not relevant on getDefaultServers(List rsGroupInfoList) method.
but this PR is already merged. shall i create new PR

…group Closes #2053 Signed-off-by: Viraj Jasani <[email protected]>

…group Closes apache#2053 Signed-off-by: Viraj Jasani <[email protected]>

…group Closes apache#2053 Author: Mohammad Arshad Reason: Bug Ref: CDPD-15964 Signed-off-by: Viraj Jasani <[email protected]> Change-Id: I895e3f52e8b1b2a5d5bf3955e0526a09ad2748d1 (cherry picked from commit a2c63df)

…group Closes apache#2053 Signed-off-by: Viraj Jasani <[email protected]> (cherry picked from commit 8dec49a) Change-Id: I895e3f52e8b1b2a5d5bf3955e0526a09ad2748d1

arshadmohammad mentioned this pull request Jul 12, 2020

HBASE-24675: On Master restart all servers are assigned to default rs… #2043

Closed

virajjasani approved these changes Jul 13, 2020

View reviewed changes

arshadmohammad force-pushed the HBASE-24675-master branch from ee40730 to 6e7346a Compare July 13, 2020 11:35

HBASE-24675: On Master restart all servers are assigned to default rs…

6e7346a

…group.

virajjasani closed this in 1781185 Jul 17, 2020

virajjasani pushed a commit that referenced this pull request Jul 17, 2020

HBASE-24675: On Master restart all servers are assigned to default rs…

e08da3b

…group Closes #2053 Signed-off-by: Viraj Jasani <[email protected]>

virajjasani pushed a commit that referenced this pull request Jul 17, 2020

HBASE-24675: On Master restart all servers are assigned to default rs…

03164ab

…group Closes #2053 Signed-off-by: Viraj Jasani <[email protected]>

anoopsjohn reviewed Jul 20, 2020

View reviewed changes

virajjasani pushed a commit that referenced this pull request Jul 23, 2020

HBASE-24675: On Master restart all servers are assigned to default rs…

8dec49a

…group Closes #2053 Signed-off-by: Viraj Jasani <[email protected]>

clarax pushed a commit to clarax/hbase that referenced this pull request Nov 15, 2020

HBASE-24675: On Master restart all servers are assigned to default rs…

4c1ddfe

…group Closes apache#2053 Signed-off-by: Viraj Jasani <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-24675: On Master restart all servers are assigned to default rs… #2053

HBASE-24675: On Master restart all servers are assigned to default rs… #2053

arshadmohammad commented Jul 12, 2020

Apache-HBase commented Jul 12, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

virajjasani left a comment

virajjasani Jul 13, 2020

anoopsjohn Jul 20, 2020

arshadmohammad Jul 20, 2020

virajjasani commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

anoopsjohn Jul 20, 2020

arshadmohammad Jul 20, 2020

HBASE-24675: On Master restart all servers are assigned to default rs… #2053

HBASE-24675: On Master restart all servers are assigned to default rs… #2053

Conversation

arshadmohammad commented Jul 12, 2020

Apache-HBase commented Jul 12, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

virajjasani left a comment

Choose a reason for hiding this comment

virajjasani Jul 13, 2020

Choose a reason for hiding this comment

anoopsjohn Jul 20, 2020

Choose a reason for hiding this comment

arshadmohammad Jul 20, 2020

Choose a reason for hiding this comment

virajjasani commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

Apache-HBase commented Jul 13, 2020

anoopsjohn Jul 20, 2020

Choose a reason for hiding this comment

arshadmohammad Jul 20, 2020

Choose a reason for hiding this comment