Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-24037 Add ut for root dir and wal root dir are different #1336

Merged
merged 1 commit into from
Mar 25, 2020
Merged

HBASE-24037 Add ut for root dir and wal root dir are different #1336

merged 1 commit into from
Mar 25, 2020

Conversation

infraio
Copy link
Contributor

@infraio infraio commented Mar 24, 2020

No description provided.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 20s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+1 💚 mvninstall 6m 23s master passed
+1 💚 checkstyle 1m 15s master passed
-1 ❌ spotbugs 2m 22s hbase-server in master has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+1 💚 mvninstall 6m 10s the patch passed
+1 💚 checkstyle 1m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 hadoopcheck 12m 11s Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.
+1 💚 spotbugs 2m 28s the patch passed
_ Other Tests _
+1 💚 asflicense 0m 14s The patch does not generate ASF License warnings.
42m 15s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #1336
Optional Tests dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle
uname Linux c33bb7ed15fe 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bdcfd6a
spotbugs https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html
Max. process+thread count 83 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 29s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 5m 45s master passed
+1 💚 compile 0m 59s master passed
+1 💚 shadedjars 5m 6s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 38s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 5m 29s the patch passed
+1 💚 compile 1m 0s the patch passed
+1 💚 javac 1m 0s the patch passed
+1 💚 shadedjars 5m 0s patch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 36s the patch passed
_ Other Tests _
+1 💚 unit 62m 46s hbase-server in the patch passed.
90m 5s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR #1336
Optional Tests javac javadoc unit shadedjars compile
uname Linux c0dce18fee7a 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bdcfd6a
Default Java 1.8.0_232
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/testReport/
Max. process+thread count 5851 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 34s Docker mode activated.
-0 ⚠️ yetus 0m 2s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 6m 41s master passed
+1 💚 compile 1m 10s master passed
-1 ❌ shadedjars 0m 10s branch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 0m 47s hbase-server in master failed.
_ Patch Compile Tests _
+1 💚 mvninstall 10m 9s the patch passed
+1 💚 compile 1m 49s the patch passed
+1 💚 javac 1m 49s the patch passed
-1 ❌ shadedjars 0m 17s patch has 7 errors when building our shaded downstream artifacts.
-0 ⚠️ javadoc 1m 6s hbase-server in the patch failed.
_ Other Tests _
-0 ⚠️ unit 108m 19s hbase-server in the patch failed.
133m 31s
Subsystem Report/Notes
Docker Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR #1336
Optional Tests javac javadoc unit shadedjars compile
uname Linux 866e94f1458e 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / bdcfd6a
Default Java 2020-01-14
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
shadedjars https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt
javadoc https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/testReport/
Max. process+thread count 5758 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1336/1/console
versions git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack
saintstack approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@saintstack saintstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed. LGTM

@saintstack
Copy link
Contributor

I think the shaded jars complaint fixed by Nick push this morning.

[WARNING] Rule 0: org.apache.maven.plugins.enforcer.RequireProperty failed with message:
HBase with JDK11 requires Hadoop3. Activate the profile with -Dhadoop.profile=3.0.

Spotbugs is from another issue.

So, still +1 on merge.

@infraio infraio merged commit eed730e into apache:master Mar 25, 2020
@infraio infraio deleted the HBASE-24037 branch March 25, 2020 02:53
asfgit pushed a commit that referenced this pull request Mar 25, 2020
@infraio
HBASE-24037 Add ut for root dir and wal root dir are different (#1336)
41baf71 
Signed-off-by: stack <[email protected]>
asfgit pushed a commit that referenced this pull request Mar 25, 2020
@infraio
HBASE-24037 Add ut for root dir and wal root dir are different (#1336)
88ac6db 
Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@infraio @thangTang
HBASE-24037 Add ut for root dir and wal root dir are different (apach…
659bf18 
…e#1336)

Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@infraio @thangTang
HBASE-24037 Add ut for root dir and wal root dir are different (apach…
7c42ab2 
…e#1336)

Signed-off-by: stack <[email protected]>
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@infraio @thangTang
HBASE-24037 Add ut for root dir and wal root dir are different (apach…
1311b78 
…e#1336)

Signed-off-by: stack <[email protected]>
infraio added a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@infraio
HBASE-24037 Add ut for root dir and wal root dir are different (apach…
7e13a10 
…e#1336)

Signed-off-by: stack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@infraio @Apache-HBase @saintstack