HBASE-23914 : Set hbase.client.retries.number for TestThriftHBaseServ…

[virajjasani]

…iceHandler

[Apache-HBase]

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+1 💚	mvninstall	5m 29s	master passed
+1 💚	compile	0m 35s	master passed
+1 💚	checkstyle	0m 42s	master passed
+1 💚	shadedjars	4m 37s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 34s	master passed
+0 🆗	spotbugs	1m 35s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	1m 34s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	compile	0m 34s	the patch passed
+1 💚	javac	0m 34s	the patch passed
+1 💚	checkstyle	0m 40s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	4m 41s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 19s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 37s	the patch passed
+1 💚	findbugs	1m 55s	the patch passed
		_ Other Tests _
+1 💚	unit	2m 11s	hbase-thrift in the patch passed.
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		54m 26s

Subsystem	Report/Notes
Docker	Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1227/1/artifact/out/Dockerfile
GITHUB PR	#1227
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 8377718aa2ff 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1227/out/precommit/personality/provided.sh
git revision	master / a420f04
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1227/1/testReport/
Max. process+thread count	3143 (vs. ulimit of 10000)
modules	C: hbase-thrift U: hbase-thrift
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1227/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

[virajjasani]

Thanks for the review @HorizonNet

[saintstack]

I've seen this happen. How does this help? Were the default retries incorrect? On timeout, we'd retried, no?

I'm game for pushign this though to see if it helps.

[virajjasani]

I've seen this happen. How does this help? Were the default retries incorrect? On timeout, we'd retried, no?

I'm game for pushign this though to see if it helps.

Since the default value is 15, I have seen multiple tests not working with default value, will need to see if default interval is too much may be for test to timeout. But yes, many tests have 3/5 values and they go quite smooth (specifically ones that need to test Exceptions after intended things don't work, something similar)