-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HBASE-23665: Split unit tests from TestTableName into a separate test… #1051
Conversation
@ndimiduk Here is the back port for branch-1. So many conflicts due to client api changes, but mostly trivial. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
Hmm, its weird that only this patch is running into the flaky maven download issue. Patch didn't touch anything in the build system. Digging into it to see if I can find some clues.
|
Ah found it... here is the reason: https://blog.sonatype.com/central-repository-moving-to-https |
We pull dependencies over http? 😱 |
@ndimiduk I think this has to do with the mvn version. Maven 3.2.3 and later fixed it out of the box[1]. Apache repos are https by default. Only the central repo is defaulting to http. |
5238072
to
736d83a
Compare
Yep, I followed the other PR. Thanks for tracking it down. |
💔 -1 overall
This message was automatically generated. |
…-only class. (apache#1032) Signed-off-by: Nick Dimiduk <[email protected]>
736d83a
to
75c594a
Compare
Fixed the check style nit and removed some dead code. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only test that failed looks like a flake, works for me locally. I kicked off another test run, just to be sure.
🎊 +1 overall
This message was automatically generated. |
…-only class. (#1032)
Signed-off-by: Nick Dimiduk [email protected]