HBASE-23621 Reduced the number of Checkstyle violations in tests of hbase-common #1030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
HorizonNet
force-pushed
the
HBASE-23621_branch-1
branch
from
67a40db to
f66a2d9
Compare
This comment has been minimized.
This comment has been minimized.
|
🎊 +1 overall
This message was automatically generated. |
busbey
reviewed
Jan 15, 2020
| * licenses this file to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| /** |
There was a problem hiding this comment.
this is a file header and not a javadoc, shouldn't it be using /* and not /**?
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
saintstack
approved these changes
Jan 23, 2020
| consume(doCreateCellScanner(1, 1), 1 * 1); | ||
| consume(doCreateCellScanner(3, 0), 3 * 0); | ||
| consume(doCreateCellScanner(1, 1), 1); | ||
| consume(doCreateCellScanner(3, 0), 0); |
| private int baseTimestampDivide = 1000000; | ||
| private int timestampDiffSize = 100000000; | ||
| private int baseTimestampDivide; | ||
| private int timestampDiffSize; |
There was a problem hiding this comment.
The values are overwritten later?
There was a problem hiding this comment.
They are both overwritten in the constructor above.
|
I'm still +1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #967 to branch-1.