HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore #1026

binlijin · 2020-01-13T02:47:12Z

No description provided.

Apache-HBase · 2020-01-13T06:46:43Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 14s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-0 ⚠️	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ master Compile Tests _
+0 🆗	mvndep	0m 36s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 40s	master passed
+1 💚	compile	1m 16s	master passed
+1 💚	checkstyle	1m 44s	master passed
+1 💚	shadedjars	5m 2s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	master passed
+0 🆗	spotbugs	5m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 37s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 12s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
+1 💚	checkstyle	1m 46s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 5s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 19s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	5m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 41s	hbase-procedure in the patch passed.
+1 💚	unit	156m 21s	hbase-server in the patch passed.
+1 💚	asflicense	0m 56s	The patch does not generate ASF License warnings.
		231m 30s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 336599b1b7e7 4.15.0-66-generic #75-Ubuntu SMP Tue Oct 1 05:24:09 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `0bf933b`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/testReport/
Max. process+thread count	5069 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/1/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

HorizonNet

LGTM overall. Can you also add test cases to ensure we don't run into this one again (at least for the AssignmentManager)?

bharathv

Stumbled upon this change. It looks like Nullable annotations are not a standard but curious whats the community's take on it.

hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

binlijin · 2020-01-14T12:03:41Z

LGTM overall. Can you also add test cases to ensure we don't run into this one again (at least for the AssignmentManager)?

Done.

Apache-HBase · 2020-01-14T16:21:25Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 1s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 43s	master passed
+1 💚	compile	1m 15s	master passed
+1 💚	checkstyle	1m 43s	master passed
+1 💚	shadedjars	4m 58s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
+0 🆗	spotbugs	5m 3s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 36s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 27s	the patch passed
+1 💚	compile	1m 15s	the patch passed
+1 💚	javac	1m 15s	the patch passed
+1 💚	checkstyle	1m 40s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 0s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 9s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	5m 34s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 45s	hbase-procedure in the patch passed.
+1 💚	unit	157m 7s	hbase-server in the patch passed.
+1 💚	asflicense	0m 55s	The patch does not generate ASF License warnings.
		227m 52s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 959f54e97394 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `499ff32`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/testReport/
Max. process+thread count	4928 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/2/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv

Thanks for adding the annotations. Few comments in the added test. Mind cleaning it up?

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

bharathv · 2020-01-14T17:44:36Z

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

+/**
+ * Base class for AM test.
+ */
+@Category({ MasterTests.class, LargeTests.class })


This would be MediumTest, no?

bharathv · 2020-01-14T17:45:36Z

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

+  protected HBaseTestingUtility util;
+
+  protected void setupConfiguration(Configuration conf) throws Exception {
+    FSUtils.setRootDir(conf, util.getDataTestDir());


Again looks like a remnant of copy+paste from TestAssignment...

bharathv · 2020-01-14T17:45:59Z

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

+      this.util.createTable(tableName, "f");
+      this.util.waitTableAvailable(tableName);
+    } finally {
+      this.util.killMiniHBaseCluster();


Move to tearDown()?

I think it's better to have a shutdown, instead of kill the cluster, in tearDown. Also seems that an assertion in this test is missing.

The test is failed when startMiniCluster without this patch.

[INFO] Running org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 210.246 s <<< FAILURE! - in org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore
[ERROR] org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore Time elapsed: 210.054 s <<< ERROR!
java.io.IOException: Shutting down
at org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore(TestDeadServerMetricRegionChore.java:60)
Caused by: java.lang.RuntimeException: Master not initialized after 200000ms
at org.apache.hadoop.hbase.master.assignment.TestDeadServerMetricRegionChore.testDeadServerMetricRegionChore(TestDeadServerMetricRegionChore.java:60)

Is the shutdown failing or because it is part of the tearDown?

The shutdown has no problem, i already change killMiniHBaseCluster
to shutdownMiniCluster.

Apache-HBase · 2020-01-15T06:02:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 41s	master passed
+1 💚	compile	1m 14s	master passed
+1 💚	checkstyle	1m 48s	master passed
+1 💚	shadedjars	5m 28s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	master passed
+0 🆗	spotbugs	5m 23s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	6m 3s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 31s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
-1 ❌	checkstyle	1m 30s	hbase-server: The patch generated 2 new + 9 unchanged - 0 fixed = 11 total (was 9)
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 11s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 47s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	6m 4s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 58s	hbase-procedure in the patch passed.
+1 💚	unit	158m 57s	hbase-server in the patch passed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		232m 13s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9e584873e6ac 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `499ff32`
Default Java	1.8.0_181
checkstyle	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/artifact/out/diff-checkstyle-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/testReport/
Max. process+thread count	5425 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/3/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-01-15T10:34:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 32s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 44s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	checkstyle	1m 49s	master passed
+1 💚	shadedjars	5m 32s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 59s	master passed
+0 🆗	spotbugs	5m 5s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 42s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 27s	the patch passed
+1 💚	compile	1m 25s	the patch passed
+1 💚	javac	1m 25s	the patch passed
+1 💚	checkstyle	1m 48s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	18m 15s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 59s	the patch passed
+1 💚	findbugs	6m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 58s	hbase-procedure in the patch passed.
+1 💚	unit	179m 18s	hbase-server in the patch passed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		254m 2s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 09e49d4ba3cb 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `4e60583`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/testReport/
Max. process+thread count	5360 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/4/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

bharathv · 2020-01-15T16:54:00Z

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

@@ -0,0 +1,68 @@
+/**


You mean change "/**" to "/*" ? I see other tests all use "/**" no one use "/*"

/** is interpreted as a javadoc in IDEs. If you notice others' changes, people are switching to /* incrementally in their patches (files they are touching). Now that you are adding a new class, it is better to start with /*.

OK, thanks for you explanation.

Apache-HBase · 2020-01-16T12:31:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 21s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 34s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 53s	master passed
+1 💚	compile	1m 18s	master passed
+1 💚	checkstyle	1m 43s	master passed
+1 💚	shadedjars	5m 10s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 57s	master passed
+0 🆗	spotbugs	5m 28s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	6m 5s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 15s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 30s	the patch passed
+1 💚	compile	1m 30s	the patch passed
+1 💚	javac	1m 30s	the patch passed
+1 💚	checkstyle	1m 52s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 29s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	18m 50s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	5m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 47s	hbase-procedure in the patch passed.
-1 ❌	unit	164m 52s	hbase-server in the patch failed.
+1 💚	asflicense	0m 48s	The patch does not generate ASF License warnings.
		240m 47s

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestRegionMoveAndAbandon
	hadoop.hbase.master.TestMasterNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 9e89df078a8f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `19d3bed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/testReport/
Max. process+thread count	4742 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/5/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-01-16T16:36:05Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 43s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 37s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 59s	master passed
+1 💚	compile	1m 32s	master passed
+1 💚	checkstyle	1m 49s	master passed
+1 💚	shadedjars	5m 20s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	1m 7s	master passed
+0 🆗	spotbugs	5m 32s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	6m 10s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 17s	Maven dependency ordering for patch
+1 💚	mvninstall	6m 8s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	checkstyle	1m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 1s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 22s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 52s	the patch passed
+1 💚	findbugs	5m 36s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 36s	hbase-procedure in the patch passed.
-1 ❌	unit	169m 24s	hbase-server in the patch failed.
+1 💚	asflicense	0m 54s	The patch does not generate ASF License warnings.
		243m 34s

Reason	Tests
Failed junit tests	hadoop.hbase.TestHBaseTestingUtility
	hadoop.hbase.master.assignment.TestRegionMoveAndAbandon
	hadoop.hbase.master.TestMasterNoCluster

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 1261dfc1fa9a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `19d3bed`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/testReport/
Max. process+thread count	5047 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/6/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-01-17T06:03:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	4m 51s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 33s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 45s	master passed
+1 💚	compile	1m 19s	master passed
+1 💚	checkstyle	1m 47s	master passed
+1 💚	shadedjars	4m 56s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 51s	master passed
+0 🆗	spotbugs	5m 0s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 32s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 26s	the patch passed
+1 💚	compile	1m 23s	the patch passed
+1 💚	javac	1m 23s	the patch passed
+1 💚	checkstyle	1m 45s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 2s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 22s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 54s	the patch passed
+1 💚	findbugs	5m 49s	the patch passed
		_ Other Tests _
+1 💚	unit	3m 44s	hbase-procedure in the patch passed.
-1 ❌	unit	167m 37s	hbase-server in the patch failed.
+1 💚	asflicense	0m 47s	The patch does not generate ASF License warnings.
		242m 49s

Reason	Tests
Failed junit tests	hadoop.hbase.master.assignment.TestRegionMoveAndAbandon

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 5fadedbbb580 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `00fc467`
Default Java	1.8.0_181
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/artifact/out/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/testReport/
Max. process+thread count	5457 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/7/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-02-05T21:53:17Z

Rerunning build. @bharathv , you approving this change sir?

bharathv

@saintstack There were a couple of comments that weren't addressed since the last review. +1 once they are addressed.
@binlijin FYI.

+1

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

Apache-HBase · 2020-02-06T00:44:40Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	3m 59s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 38s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 53s	master passed
+1 💚	compile	1m 23s	master passed
+1 💚	checkstyle	1m 29s	master passed
+1 💚	shadedjars	5m 8s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 53s	master passed
+0 🆗	spotbugs	4m 27s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 0s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 13s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 32s	the patch passed
+1 💚	compile	1m 18s	the patch passed
+1 💚	javac	1m 18s	the patch passed
+1 💚	checkstyle	1m 30s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 6s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 43s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 50s	the patch passed
+1 💚	findbugs	5m 30s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 49s	hbase-procedure in the patch passed.
+1 💚	unit	99m 24s	hbase-server in the patch passed.
+1 💚	asflicense	0m 56s	The patch does not generate ASF License warnings.
		171m 11s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux dd1b8cc91996 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `b49ec58`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/testReport/
Max. process+thread count	6551 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/8/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

binlijin

@bharathv The latest patch should have addressed all you comment.

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java

Apache-HBase · 2020-02-06T10:12:01Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ master Compile Tests _
+0 🆗	mvndep	0m 40s	Maven dependency ordering for branch
+1 💚	mvninstall	5m 52s	master passed
+1 💚	compile	1m 17s	master passed
+1 💚	checkstyle	1m 30s	master passed
+1 💚	shadedjars	5m 3s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 52s	master passed
+0 🆗	spotbugs	4m 56s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 30s	master passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 14s	Maven dependency ordering for patch
+1 💚	mvninstall	5m 34s	the patch passed
+1 💚	compile	1m 19s	the patch passed
+1 💚	javac	1m 19s	the patch passed
+1 💚	checkstyle	1m 29s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedjars	5m 3s	patch has no errors when building our shaded downstream artifacts.
+1 💚	hadoopcheck	17m 36s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚	javadoc	0m 51s	the patch passed
+1 💚	findbugs	5m 33s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 42s	hbase-procedure in the patch passed.
+1 💚	unit	92m 1s	hbase-server in the patch passed.
+1 💚	asflicense	0m 50s	The patch does not generate ASF License warnings.
		161m 16s

Subsystem	Report/Notes
Docker	Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/artifact/out/Dockerfile
GITHUB PR	#1026
Optional Tests	dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname	Linux 11c36c70826d 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool	maven
Personality	/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1026/out/precommit/personality/provided.sh
git revision	master / `867b1e9`
Default Java	1.8.0_181
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/testReport/
Max. process+thread count	7291 (vs. ulimit of 10000)
modules	C: hbase-procedure hbase-server U: .
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1026/9/console
versions	git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

bharathv

@HorizonNet You were looking at this too, any more comments or is this good to go?

…1026) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

…1151) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

…1026) Signed-off-by: Bharath Vissapragada <[email protected]>

…1026) (apache#1151) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

binlijin added the bug label Jan 13, 2020

HorizonNet reviewed Jan 13, 2020

View reviewed changes

bharathv reviewed Jan 14, 2020

View reviewed changes

hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java Show resolved Hide resolved

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated Show resolved Hide resolved

bharathv requested changes Jan 14, 2020

View reviewed changes

bharathv requested changes Jan 15, 2020

View reviewed changes

binlijin force-pushed the HBASE-23682 branch from 0c60ab4 to 5689acd Compare January 16, 2020 10:40

binlijin force-pushed the HBASE-23682 branch from 182ac1a to 6580fa0 Compare January 17, 2020 01:50

bharathv reviewed Feb 5, 2020

View reviewed changes

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java Outdated Show resolved Hide resolved

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Show resolved Hide resolved

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore

c5b7eb8

binlijin force-pushed the HBASE-23682 branch from 6580fa0 to c5b7eb8 Compare February 6, 2020 07:28

binlijin commented Feb 6, 2020

View reviewed changes

...src/test/java/org/apache/hadoop/hbase/master/assignment/TestDeadServerMetricRegionChore.java Show resolved Hide resolved

bharathv approved these changes Feb 6, 2020

View reviewed changes

bharathv reviewed Feb 7, 2020

View reviewed changes

bharathv merged commit 24823ec into apache:master Feb 8, 2020

bharathv pushed a commit to bharathv/hbase that referenced this pull request Feb 8, 2020

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…

fa396f3

…1026) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

bharathv added a commit that referenced this pull request Feb 9, 2020

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (#1026) (#…

40c37dd

…1151) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…

5ef1add

…1026) Signed-off-by: Bharath Vissapragada <[email protected]>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…

3b8b98d

…1026) Signed-off-by: Bharath Vissapragada <[email protected]>

infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore (apache#…

75a4502

…1026) (apache#1151) Signed-off-by: Bharath Vissapragada <[email protected]> (cherry picked from commit 24823ec)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore #1026

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore #1026

binlijin commented Jan 13, 2020

Apache-HBase commented Jan 13, 2020

HorizonNet left a comment

bharathv left a comment

binlijin commented Jan 14, 2020

Apache-HBase commented Jan 14, 2020

bharathv left a comment

bharathv Jan 14, 2020

binlijin Jan 15, 2020

bharathv Jan 14, 2020

binlijin Jan 15, 2020

bharathv Jan 14, 2020

HorizonNet Jan 14, 2020

binlijin Jan 15, 2020 •

edited

Loading

HorizonNet Jan 16, 2020

binlijin Jan 16, 2020 •

edited

Loading

Apache-HBase commented Jan 15, 2020

Apache-HBase commented Jan 15, 2020

bharathv Jan 15, 2020

binlijin Jan 16, 2020 •

edited

Loading

bharathv Jan 16, 2020

binlijin Jan 16, 2020

Apache-HBase commented Jan 16, 2020

Apache-HBase commented Jan 16, 2020

Apache-HBase commented Jan 17, 2020

saintstack commented Feb 5, 2020

bharathv left a comment

Apache-HBase commented Feb 6, 2020

binlijin left a comment

Apache-HBase commented Feb 6, 2020

bharathv left a comment

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore #1026

HBASE-23682 Fix NPE when disable DeadServerMetricRegionChore #1026

Conversation

binlijin commented Jan 13, 2020

Apache-HBase commented Jan 13, 2020

HorizonNet left a comment

Choose a reason for hiding this comment

bharathv left a comment

Choose a reason for hiding this comment

binlijin commented Jan 14, 2020

Apache-HBase commented Jan 14, 2020

bharathv left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

binlijin Jan 15, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

binlijin Jan 16, 2020 • edited Loading

Choose a reason for hiding this comment

Apache-HBase commented Jan 15, 2020

Apache-HBase commented Jan 15, 2020

Choose a reason for hiding this comment

binlijin Jan 16, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Apache-HBase commented Jan 16, 2020

Apache-HBase commented Jan 16, 2020

Apache-HBase commented Jan 17, 2020

saintstack commented Feb 5, 2020

bharathv left a comment

Choose a reason for hiding this comment

Apache-HBase commented Feb 6, 2020

binlijin left a comment

Choose a reason for hiding this comment

Apache-HBase commented Feb 6, 2020

bharathv left a comment

Choose a reason for hiding this comment

binlijin Jan 15, 2020 •

edited

Loading

binlijin Jan 16, 2020 •

edited

Loading

binlijin Jan 16, 2020 •

edited

Loading