HBASE-24854 Correct the help content of assign and unassign commands …

…in hbase shell Closes #2241 Signed-off-by: Viraj Jasani <[email protected]> Signed-off-by: Wellington Chevreuil <[email protected]>
apache · Aug 13, 2020 · c81ef73 · c81ef73
1 parent d2eb69d
commit c81ef73
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 7 deletions.
diff --git a/hbase-shell/src/main/ruby/shell/commands/assign.rb b/hbase-shell/src/main/ruby/shell/commands/assign.rb
@@ -22,8 +22,10 @@ module Commands
     class Assign < Command
       def help
         <<-EOF
-Assign a region. Use with caution. If region already assigned,
-this command will do a force reassign. For experts only.
+Assign a region. It could be executed only when region in expected state(CLOSED, OFFLINE).
+In addition, you can use "assigns" command available on HBCK2 tool to skip the state check.
+(For more info on HBCK2: https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md)
+Use with caution. For experts only.
 Examples:
 
   hbase> assign 'REGIONNAME'

diff --git a/hbase-shell/src/main/ruby/shell/commands/unassign.rb b/hbase-shell/src/main/ruby/shell/commands/unassign.rb
@@ -22,11 +22,14 @@ module Commands
     class Unassign < Command
       def help
         <<-EOF
-Unassign a region. Unassign will close region in current location and then
-reopen it again.  Pass 'true' to force the unassignment ('force' will clear
-all in-memory state in master before the reassign. If results in
-double assignment use hbck -fix to resolve. To be used by experts).
-Use with caution.  For expert use only.  Examples:
+Unassign a region. It could be executed only when region in expected state(OPEN).
+Pass 'true' to force the unassignment ('force' will clear all in-memory state in
+master before the reassign. If results in double assignment use hbck -fix to resolve.
+To be used by experts).
+In addition, you can use "unassigns" command available on HBCK2 tool to skip the state check.
+(For more info on HBCK2: https://github.com/apache/hbase-operator-tools/blob/master/hbase-hbck2/README.md)
+Use with caution. For experts only.
+Examples:
 
   hbase> unassign 'REGIONNAME'
   hbase> unassign 'REGIONNAME', true