HBASE-28959 Output fsreadtime in SlowLogPayLoad to hbase:slowlog (#6502)

Signed-off-by: Ray Mattingly <[email protected]> Signed-off-by: Viraj Jasani <[email protected]>
apache · Dec 12, 2024 · c702fab · c702fab
1 parent b622302
commit c702fab
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
@@ -83,6 +83,8 @@ public static void addSlowLogRecords(final List<TooSlowLog.SlowLogPayload> slowL
           Bytes.toBytes(Integer.toString(slowLogPayload.getProcessingTime())))
         .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("queue_time"),
           Bytes.toBytes(Integer.toString(slowLogPayload.getQueueTime())))
+        .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("fs_read_time"),
+          Bytes.toBytes(Long.toString(slowLogPayload.getFsReadTime())))
         .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("region_name"),
           Bytes.toBytes(slowLogPayload.getRegionName()))
         .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("response_size"),

diff --git a/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp b/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp
@@ -97,6 +97,7 @@
             <th>Start Time</th>
             <th>Processing Time</th>
             <th>Queue Time</th>
+            <th>FsRead Time</th>
             <th>Response Size</th>
             <th>Block Bytes Scanned</th>
             <th>Client Address</th>
@@ -118,8 +119,9 @@
              <td><%=new Date(r.getStartTime() + 1800*1000)%></td>
              <td><%=r.getProcessingTime()%>ms</td>
              <td><%=r.getQueueTime()%>ms</td>
+             <td><%=r.getFsReadTime()%>ms</td>
              <td><%=StringUtils.byteDesc(r.getResponseSize())%></td>
-              <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
+             <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
              <td><%=r.getClientAddress()%></td>
              <td><%=r.getServerClass()%></td>
              <td><%=r.getMethodName()%></td>
@@ -144,6 +146,7 @@
             <th>Start Time</th>
             <th>Processing Time</th>
             <th>Queue Time</th>
+            <th>FsRead Time</th>
             <th>Response Size</th>
             <th>Block Bytes Scanned</th>
             <th>Client Address</th>
@@ -165,8 +168,9 @@
              <td><%=new Date(r.getStartTime() + 1800*1000)%></td>
              <td><%=r.getProcessingTime()%>ms</td>
              <td><%=r.getQueueTime()%>ms</td>
+             <td><%=r.getFsReadTime()%>ms</td>
              <td><%=StringUtils.byteDesc(r.getResponseSize())%></td>
-              <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
+             <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
              <td><%=r.getClientAddress()%></td>
              <td><%=r.getServerClass()%></td>
              <td><%=r.getMethodName()%></td>