removing redundant updateCachedLocationOnError

apache · Oct 8, 2019 · a2a4082 · a2a4082
1 parent 8ca960c
commit a2a4082
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncMetaRegionLocator.java
@@ -109,7 +109,7 @@ private void removeLocationFromCache(HRegionLocation loc) {
 
   void updateCachedLocationOnError(HRegionLocation loc, Throwable exception) {
     AsyncRegionLocatorHelper.updateCachedLocationOnError(loc, exception, this::getCacheLocation,
-      this::addLocationToCache, this::removeLocationFromCache);
+      this::addLocationToCache, this::removeLocationFromCache, null);
   }
 
   void clearCache() {

diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocatorHelper.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRegionLocatorHelper.java
@@ -49,13 +49,6 @@ static boolean canUpdateOnError(HRegionLocation loc, HRegionLocation oldLoc) {
       oldLoc.getServerName().equals(loc.getServerName());
   }
 
-  static void updateCachedLocationOnError(HRegionLocation loc, Throwable exception,
-      Function<HRegionLocation, HRegionLocation> cachedLocationSupplier,
-      Consumer<HRegionLocation> addToCache, Consumer<HRegionLocation> removeFromCache) {
-    updateCachedLocationOnError(loc, exception, cachedLocationSupplier, addToCache,
-      removeFromCache, null);
-  }
-
   static void updateCachedLocationOnError(HRegionLocation loc, Throwable exception,
       Function<HRegionLocation, HRegionLocation> cachedLocationSupplier,
       Consumer<HRegionLocation> addToCache, Consumer<HRegionLocation> removeFromCache,