-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-22738 Fallback to default group to choose RS when there are no …
…RS in current group
- Loading branch information
Showing
3 changed files
with
154 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
hbase-rsgroup/src/test/java/org/apache/hadoop/hbase/rsgroup/TestRSGroupsFallback.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| package org.apache.hadoop.hbase.rsgroup; | ||
|
|
||
| import static org.junit.Assert.assertTrue; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.Collections; | ||
|
|
||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; | ||
| import org.apache.hadoop.hbase.client.TableDescriptor; | ||
| import org.apache.hadoop.hbase.client.TableDescriptorBuilder; | ||
| import org.apache.hadoop.hbase.master.assignment.AssignmentTestingUtil; | ||
| import org.apache.hadoop.hbase.net.Address; | ||
| import org.apache.hadoop.hbase.testclassification.MediumTests; | ||
| import org.apache.hadoop.hbase.util.Bytes; | ||
| import org.junit.After; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @Category(MediumTests.class) | ||
| public class TestRSGroupsFallback extends TestRSGroupsBase { | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestRSGroupsFallback.class); | ||
|
|
||
| protected static final Logger LOG = LoggerFactory.getLogger(TestRSGroupsFallback.class); | ||
|
|
||
| private static final String FALLBACK_GROUP = "fallback"; | ||
|
|
||
| @BeforeClass | ||
| public static void setUp() throws Exception { | ||
| Configuration configuration = TEST_UTIL.getConfiguration(); | ||
| configuration.set(RSGroupBasedLoadBalancer.FALLBACK_GROUPS_KEY, FALLBACK_GROUP); | ||
| setUpTestBeforeClass(); | ||
| master.balanceSwitch(true); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDown() throws Exception { | ||
| tearDownAfterClass(); | ||
| } | ||
|
|
||
| @Before | ||
| public void beforeMethod() throws Exception { | ||
| setUpBeforeMethod(); | ||
| } | ||
|
|
||
| @After | ||
| public void afterMethod() throws Exception { | ||
| tearDownAfterMethod(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testGroupFallback() throws Exception { | ||
| // add fallback group | ||
| addGroup(FALLBACK_GROUP, 1); | ||
| // add test group | ||
| String groupName = getGroupName(name.getMethodName()); | ||
| addGroup(groupName, 1); | ||
| TableDescriptor desc = TableDescriptorBuilder.newBuilder(tableName) | ||
| .setColumnFamily(ColumnFamilyDescriptorBuilder.newBuilder(Bytes.toBytes("f")).build()) | ||
| .build(); | ||
| admin.createTable(desc); | ||
| rsGroupAdmin.moveTables(Collections.singleton(tableName), groupName); | ||
| TEST_UTIL.waitUntilAllRegionsAssigned(tableName); | ||
| // server of test group crash | ||
| for (Address server : rsGroupAdmin.getRSGroupInfo(groupName).getServers()) { | ||
| AssignmentTestingUtil.crashRs(TEST_UTIL, getServerName(server), true); | ||
| } | ||
| TEST_UTIL.waitUntilNoRegionsInTransition(10000); | ||
| TEST_UTIL.waitUntilAllRegionsAssigned(tableName); | ||
|
|
||
| // regions move to fallback group | ||
| assertRegionsInGroup(FALLBACK_GROUP); | ||
|
|
||
| // move a new server from default group | ||
| Address address = rsGroupAdmin.getRSGroupInfo(RSGroupInfo.DEFAULT_GROUP).getServers() | ||
| .iterator().next(); | ||
| rsGroupAdmin.moveServers(Collections.singleton(address), groupName); | ||
|
|
||
| // correct misplaced regions | ||
| master.balance(); | ||
|
|
||
| TEST_UTIL.waitUntilNoRegionsInTransition(10000); | ||
| TEST_UTIL.waitUntilAllRegionsAssigned(tableName); | ||
|
|
||
| // regions move back | ||
| assertRegionsInGroup(groupName); | ||
|
|
||
| TEST_UTIL.deleteTable(tableName); | ||
| } | ||
|
|
||
| private void assertRegionsInGroup(String group) throws IOException { | ||
| RSGroupInfo fallbackGroup = rsGroupAdmin.getRSGroupInfo(group); | ||
| master.getAssignmentManager().getRegionStates().getRegionsOfTable(tableName).forEach(region -> { | ||
| Address regionOnServer = master.getAssignmentManager().getRegionStates() | ||
| .getRegionAssignments().get(region).getAddress(); | ||
| assertTrue(fallbackGroup.getServers().contains(regionOnServer)); | ||
| }); | ||
| } | ||
|
|
||
| } |