incorporated review comments

apache · Feb 29, 2024 · 65cd759 · 65cd759
1 parent cea0ff0
commit 65cd759
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/hbase-it/pom.xml b/hbase-it/pom.xml
@@ -38,10 +38,7 @@
     <!-- To Run Tests with a particular Xmx Value use -Dfailsafe.Xmx=XXXg -->
     <failsafe.Xmx>4g</failsafe.Xmx>
     <failsafe.jdk8.flags>-XX:+CMSClassUnloadingEnabled</failsafe.jdk8.flags>
-    <hbase-failsafe.argLine>-enableassertions -Xmx${failsafe.Xmx}
-         -Djava.security.egd=file:/dev/./urandom ${failsafe.jdk8.flags}
-	    -verbose:gc -XX:+PrintCommandLineFlags  -XX:+PrintFlagsFinal</hbase-failsafe.argLine>
-    <argLine>${hbase-failsafe.argLine} @{jacocoArgLine}</argLine>
+    <failsafe.profile.overrides>${failsafe.jdk8.flags}</failsafe.profile.overrides>
     <!-- To run a single integration test, use -Dit.test=IntegrationTestXXX -->
   </properties>
 
@@ -287,6 +284,9 @@
           <!-- TODO: failsafe does timeout, but verify does not fail the build because of the timeout.
                  I believe it is a failsafe bug, we may consider using surefire -->
           <forkedProcessTimeoutInSeconds>1800</forkedProcessTimeoutInSeconds>
+          <argLine>-enableassertions -Xmx${failsafe.Xmx}
+	         -Djava.security.egd=file:/dev/./urandom ${failsafe.profile.overrides}
+                -verbose:gc -XX:+PrintCommandLineFlags  -XX:+PrintFlagsFinal @{jacocoArgLine}</argLine>
         </configuration>
       </plugin>
       <plugin>
@@ -339,8 +339,7 @@
         <jdk>[1.11,)</jdk>
       </activation>
       <properties>
-        <failsafe.jdk8.flags/>
-        <argLine>${hbase-surefire.jdk11.flags} ${hbase-failsafe.argLine} @{jacocoArgLine}</argLine>
+        <failsafe.profile.overrides>${hbase-surefire.jdk11.flags}</failsafe.profile.overrides>
       </properties>
 
       <dependencies>