HBASE-23335 : Improving cost functions array copy in StochasticLoadBa…

…lancer Signed-off-by: stack <[email protected]>
apache · Jan 19, 2020 · 64b9d2f · 64b9d2f
1 parent dc602d7
commit 64b9d2f
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/...-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java b/...-server/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
@@ -414,9 +414,7 @@ public synchronized List<RegionPlan> balanceCluster(Map<ServerName,
 
     double currentCost = computeCost(cluster, Double.MAX_VALUE);
     curOverallCost = currentCost;
-    for (int i = 0; i < this.curFunctionCosts.length; i++) {
-      curFunctionCosts[i] = tempFunctionCosts[i];
-    }
+    System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, this.curFunctionCosts.length);
 
     double initCost = currentCost;
     double newCost = currentCost;
@@ -462,9 +460,7 @@ public synchronized List<RegionPlan> balanceCluster(Map<ServerName,
 
         // save for JMX
         curOverallCost = currentCost;
-        for (int i = 0; i < this.curFunctionCosts.length; i++) {
-          curFunctionCosts[i] = tempFunctionCosts[i];
-        }
+        System.arraycopy(tempFunctionCosts, 0, curFunctionCosts, 0, this.curFunctionCosts.length);
       } else {
         // Put things back the way they were before.
         // TODO: undo by remembering old values