-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
address review comments, and tests for hedged reads
- Loading branch information
Showing
3 changed files
with
270 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
225 changes: 225 additions & 0 deletions
225
hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestMasterRegistryHedgedReads.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,225 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.client; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertThrows; | ||
|
|
||
| import java.io.IOException; | ||
| import java.net.SocketAddress; | ||
| import java.util.Collections; | ||
| import java.util.Set; | ||
| import java.util.concurrent.CompletableFuture; | ||
| import java.util.concurrent.ExecutorService; | ||
| import java.util.concurrent.Executors; | ||
| import java.util.concurrent.atomic.AtomicInteger; | ||
| import java.util.stream.Collectors; | ||
| import java.util.stream.IntStream; | ||
| import org.apache.hadoop.conf.Configuration; | ||
| import org.apache.hadoop.hbase.HBaseCommonTestingUtility; | ||
| import org.apache.hadoop.hbase.HConstants; | ||
| import org.apache.hadoop.hbase.ServerName; | ||
| import org.apache.hadoop.hbase.ipc.HBaseRpcController; | ||
| import org.apache.hadoop.hbase.ipc.RpcClient; | ||
| import org.apache.hadoop.hbase.ipc.RpcClientFactory; | ||
| import org.apache.hadoop.hbase.security.User; | ||
| import org.apache.hadoop.hbase.testclassification.ClientTests; | ||
| import org.apache.hadoop.hbase.testclassification.SmallTests; | ||
| import org.apache.hadoop.hbase.util.FutureUtils; | ||
| import org.junit.AfterClass; | ||
| import org.junit.Before; | ||
| import org.junit.BeforeClass; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| import org.apache.hbase.thirdparty.com.google.common.util.concurrent.ThreadFactoryBuilder; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.BlockingRpcChannel; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.Descriptors.MethodDescriptor; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.Message; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.RpcCallback; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.RpcChannel; | ||
| import org.apache.hbase.thirdparty.com.google.protobuf.RpcController; | ||
|
|
||
| import org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos.GetClusterIdResponse; | ||
|
|
||
| @Category({ ClientTests.class, SmallTests.class }) | ||
| public class TestMasterRegistryHedgedReads { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(TestMasterRegistryHedgedReads.class); | ||
|
|
||
| private static final HBaseCommonTestingUtility UTIL = new HBaseCommonTestingUtility(); | ||
|
|
||
| private static final ExecutorService EXECUTOR = | ||
| Executors.newCachedThreadPool(new ThreadFactoryBuilder().setDaemon(true).build()); | ||
|
|
||
| private static AtomicInteger CALLED = new AtomicInteger(0); | ||
|
|
||
| private static volatile int BAD_RESP_INDEX; | ||
|
|
||
| private static volatile Set<Integer> GOOD_RESP_INDEXS; | ||
|
|
||
| private static GetClusterIdResponse RESP = | ||
| GetClusterIdResponse.newBuilder().setClusterId("id").build(); | ||
|
|
||
| public static final class RpcClientImpl implements RpcClient { | ||
|
|
||
| public RpcClientImpl(Configuration configuration, String clusterId, SocketAddress localAddress, | ||
| MetricsConnection metrics) { | ||
| } | ||
|
|
||
| @Override | ||
| public BlockingRpcChannel createBlockingRpcChannel(ServerName sn, User user, int rpcTimeout) | ||
| throws IOException { | ||
| throw new UnsupportedOperationException(); | ||
| } | ||
|
|
||
| @Override | ||
| public RpcChannel createRpcChannel(ServerName sn, User user, int rpcTimeout) | ||
| throws IOException { | ||
| return new RpcChannelImpl(); | ||
| } | ||
|
|
||
| @Override | ||
| public void cancelConnections(ServerName sn) { | ||
| } | ||
|
|
||
| @Override | ||
| public void close() { | ||
| } | ||
|
|
||
| @Override | ||
| public boolean hasCellBlockSupport() { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| public static final class RpcChannelImpl implements RpcChannel { | ||
|
|
||
| @Override | ||
| public void callMethod(MethodDescriptor method, RpcController controller, Message request, | ||
| Message responsePrototype, RpcCallback<Message> done) { | ||
| // simulate the asynchronous behavior otherwise all logic will perform in the same thread... | ||
| EXECUTOR.execute(() -> { | ||
| int index = CALLED.getAndIncrement(); | ||
| if (index == BAD_RESP_INDEX) { | ||
| done.run(GetClusterIdResponse.getDefaultInstance()); | ||
| } else if (GOOD_RESP_INDEXS.contains(index)) { | ||
| done.run(RESP); | ||
| } else { | ||
| ((HBaseRpcController) controller).setFailed("inject error"); | ||
| done.run(null); | ||
| } | ||
| }); | ||
| } | ||
| } | ||
|
|
||
| @BeforeClass | ||
| public static void setUpBeforeClass() { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| conf.setClass(RpcClientFactory.CUSTOM_RPC_CLIENT_IMPL_CONF_KEY, RpcClientImpl.class, | ||
| RpcClient.class); | ||
| String masters = IntStream.range(0, 10).mapToObj(i -> "localhost:" + (10000 + 100 * i)) | ||
| .collect(Collectors.joining(",")); | ||
| conf.set(HConstants.MASTER_ADDRS_KEY, masters); | ||
| } | ||
|
|
||
| @AfterClass | ||
| public static void tearDownAfterClass() { | ||
| EXECUTOR.shutdownNow(); | ||
| } | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| CALLED.set(0); | ||
| BAD_RESP_INDEX = -1; | ||
| GOOD_RESP_INDEXS = Collections.emptySet(); | ||
| } | ||
|
|
||
| private <T> T logIfError(CompletableFuture<T> future) throws IOException { | ||
| try { | ||
| return FutureUtils.get(future); | ||
| } catch (Throwable t) { | ||
| LOG.warn("", t); | ||
| throw t; | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testAllFailNoHedged() throws IOException { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| conf.setInt(MasterRegistry.MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY, 1); | ||
| try (MasterRegistry registry = new MasterRegistry(conf)) { | ||
| assertThrows(IOException.class, () -> logIfError(registry.getClusterId())); | ||
| assertEquals(10, CALLED.get()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testAllFailHedged3() throws IOException { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| conf.setInt(MasterRegistry.MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY, 3); | ||
| BAD_RESP_INDEX = 5; | ||
| try (MasterRegistry registry = new MasterRegistry(conf)) { | ||
| assertThrows(IOException.class, () -> logIfError(registry.getClusterId())); | ||
| assertEquals(10, CALLED.get()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testFirstSucceededNoHedge() throws IOException { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| // will be set to 1 | ||
| conf.setInt(MasterRegistry.MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY, 0); | ||
| GOOD_RESP_INDEXS = | ||
| IntStream.range(0, 10).mapToObj(Integer::valueOf).collect(Collectors.toSet()); | ||
| try (MasterRegistry registry = new MasterRegistry(conf)) { | ||
| String clusterId = logIfError(registry.getClusterId()); | ||
| assertEquals(RESP.getClusterId(), clusterId); | ||
| assertEquals(1, CALLED.get()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testSecondRoundSucceededHedge4() throws IOException { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| conf.setInt(MasterRegistry.MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY, 4); | ||
| GOOD_RESP_INDEXS = Collections.singleton(6); | ||
| try (MasterRegistry registry = new MasterRegistry(conf)) { | ||
| String clusterId = logIfError(registry.getClusterId()); | ||
| assertEquals(RESP.getClusterId(), clusterId); | ||
| UTIL.waitFor(5000, () -> CALLED.get() == 8); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| public void testSucceededWithLargestHedged() throws IOException, InterruptedException { | ||
| Configuration conf = UTIL.getConfiguration(); | ||
| conf.setInt(MasterRegistry.MASTER_REGISTRY_HEDGED_REQS_FANOUT_KEY, Integer.MAX_VALUE); | ||
| GOOD_RESP_INDEXS = Collections.singleton(5); | ||
| try (MasterRegistry registry = new MasterRegistry(conf)) { | ||
| String clusterId = logIfError(registry.getClusterId()); | ||
| assertEquals(RESP.getClusterId(), clusterId); | ||
| UTIL.waitFor(5000, () -> CALLED.get() == 10); | ||
| Thread.sleep(1000); | ||
| // make sure we do not send more | ||
| assertEquals(10, CALLED.get()); | ||
| } | ||
| } | ||
| } |