HBASE-28688 Correct the usage for blanks ignore options in yetus (#6026)

Signed-off-by: Guanghao Zhang <[email protected]>
(cherry picked from commit d1015a6)

dev-support/Jenkinsfile

@@ -43,7 +43,8 @@ pipeline {
     PERSONALITY_FILE = 'tools/personality.sh'
     // This section of the docs tells folks not to use the javadoc tag. older branches have our old version of the check for said tag.
     AUTHOR_IGNORE_LIST = 'src/main/asciidoc/_chapters/developer.adoc'
-    BLANKS_IGNORE_LIST = '.*/generated/.*'
+    BLANKS_EOL_IGNORE_FILE = 'dev-support/blanks-eol-ignore.txt'
+    BLANKS_TABS_IGNORE_FILE = 'dev-support/blanks-tabs-ignore.txt'
     // output from surefire; sadly the archive function in yetus only works on file names.
     ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump'
     // These tests currently have known failures. Once they burn down to 0, remove from here so that new problems will cause a failure.

dev-support/Jenkinsfile_GitHub

@@ -41,7 +41,8 @@ pipeline {
         JDK_SPECIFIC_PLUGINS = 'compile,github,htmlout,javac,javadoc,maven,mvninstall,shadedjars,unit'
         // This section of the docs tells folks not to use the javadoc tag. older branches have our old version of the check for said tag.
         AUTHOR_IGNORE_LIST = 'src/main/asciidoc/_chapters/developer.adoc'
-        BLANKS_IGNORE_LIST = '.*/generated/.*'
+        BLANKS_EOL_IGNORE_FILE = 'dev-support/blanks-eol-ignore.txt'
+        BLANKS_TABS_IGNORE_FILE = 'dev-support/blanks-tabs-ignore.txt'
         // output from surefire; sadly the archive function in yetus only works on file names.
         ARCHIVE_PATTERN_LIST = 'TEST-*.xml,org.apache.h*.txt,*.dumpstream,*.dump'
         // These tests currently have known failures. Once they burn down to 0, remove from here so that new problems will cause a failure.

dev-support/blanks-eol-ignore.txt

@@ -0,0 +1,24 @@
+##
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##
+.*/generated/.*
+# we have generated code for other languages in hbase-examples
+.*/gen-cpp/.*
+.*/gen-perl/.*
+.*/gen-php/.*
+.*/gen-py/.*
+.*/gen-rb/.*

dev-support/blanks-tabs-ignore.txt

@@ -0,0 +1,28 @@
+##
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+##
+.*/generated/.*
+# we have generated code for other languages in hbase-examples
+.*/gen-cpp/.*
+.*/gen-perl/.*
+.*/gen-php/.*
+.*/gen-py/.*
+.*/gen-rb/.*
+# we have tabs in asciidoc, not sure whether it is OK to replace them with spaces
+src/main/asciidoc/.*
+# perl officially suggests use tab instead of space for indentation
+.*/*.pl

dev-support/hbase_nightly_yetus.sh

@@ -20,8 +20,8 @@ declare -i missing_env=0
 # Validate params
 for required_env in "TESTS" "PERSONALITY_FILE" "BASEDIR" "ARCHIVE_PATTERN_LIST" "OUTPUT_DIR_RELATIVE" \
                     "OUTPUT_DIR" "PROJECT" "AUTHOR_IGNORE_LIST" \
-                    "BLANKS_IGNORE_LIST" "BRANCH_NAME" "TESTS_FILTER" "DEBUG" \
-                    "USE_YETUS_PRERELEASE" "WORKSPACE" "YETUS_RELEASE"; do
+                    "BLANKS_EOL_IGNORE_FILE" "BLANKS_TABS_IGNORE_FILE" "BRANCH_NAME" "TESTS_FILTER" \
+                    "DEBUG" "USE_YETUS_PRERELEASE" "WORKSPACE" "YETUS_RELEASE"; do
   if [ -z "${!required_env}" ]; then
     echo "[ERROR] Required environment variable '${required_env}' is not set."
     missing_env=${missing_env}+1
@@ -59,8 +59,8 @@ YETUS_ARGS=("--patch-dir=${OUTPUT_DIR}" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--project=${PROJECT}" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--resetrepo" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--author-ignore-list=${AUTHOR_IGNORE_LIST}" "${YETUS_ARGS[@]}")
-YETUS_ARGS=("--blanks-eol-ignore-list=${BLANKS_IGNORE_LIST}" "${YETUS_ARGS[@]}")
-YETUS_ARGS=("--blanks-tabs-ignore-list=${BLANKS_IGNORE_LIST}" "${YETUS_ARGS[@]}")
+YETUS_ARGS=("--blanks-eol-ignore-file=${BLANKS_EOL_IGNORE_FILE}" "${YETUS_ARGS[@]}")
+YETUS_ARGS=("--blanks-tabs-ignore-file=${BLANKS_TABS_IGNORE_FILE}" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--sentinel" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--branch=${BRANCH_NAME}" "${YETUS_ARGS[@]}")
 YETUS_ARGS=("--tests-filter=${TESTS_FILTER}" "${YETUS_ARGS[@]}")

dev-support/jenkins_precommit_github_yetus.sh

@@ -42,7 +42,8 @@ declare -a required_envs=(
   "TESTS_FILTER"
   "YETUSDIR"
   "AUTHOR_IGNORE_LIST"
-  "BLANKS_IGNORE_LIST"
+  "BLANKS_EOL_IGNORE_FILE"
+  "BLANKS_TABS_IGNORE_FILE"
 )
 # Validate params
 for required_env in "${required_envs[@]}"; do
@@ -112,8 +113,8 @@ YETUS_ARGS+=("--dockerfile=${DOCKERFILE}")
 YETUS_ARGS+=("--mvn-custom-repos")
 YETUS_ARGS+=("--java-home=${SET_JAVA_HOME}")
 YETUS_ARGS+=("--author-ignore-list=${AUTHOR_IGNORE_LIST}")
-YETUS_ARGS+=("--blanks-eol-ignore-list=${BLANKS_IGNORE_LIST}")
-YETUS_ARGS+=("--blanks-tabs-ignore-list=${BLANKS_IGNORE_LIST}*")
+YETUS_ARGS+=("--blanks-eol-ignore-file=${BLANKS_EOL_IGNORE_FILE}")
+YETUS_ARGS+=("--blanks-tabs-ignore-file=${BLANKS_TABS_IGNORE_FILE}*")
 YETUS_ARGS+=("--tests-filter=${TESTS_FILTER}")
 YETUS_ARGS+=("--personality=${SOURCEDIR}/dev-support/hbase-personality.sh")
 YETUS_ARGS+=("--quick-hadoopcheck")