HBASE-26035 Redundant null check in the compareTo function (#3433)

Signed-off-by: Duo Zhang <[email protected]>
apache · Jul 1, 2021 · 0acf4e1 · 0acf4e1
1 parent 9c7d9fa
commit 0acf4e1
Showing 1 changed file with 1 addition and 7 deletions.
diff --git a/...p2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java b/...p2-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionSourceImpl.java
@@ -180,13 +180,7 @@ public int compareTo(MetricsRegionSource source) {
     if (!(source instanceof MetricsRegionSourceImpl)) {
       return -1;
     }
-
-    MetricsRegionSourceImpl impl = (MetricsRegionSourceImpl) source;
-    if (impl == null) {
-      return -1;
-    }
-
-    return Long.compare(hashCode, impl.hashCode);
+    return Long.compare(hashCode, ((MetricsRegionSourceImpl) source).hashCode);
   }
 
   void snapshot(MetricsRecordBuilder mrb, boolean ignored) {