Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse #6013
base: branch-gvfs-fuse-dev
Are you sure you want to change the base?
[#6012] feat (gvfs-fuse): Support Gravitino S3 fileset filesystem operation in gvfs fuse #6013
Changes from 69 commits
f025216
97e066d
d0b6958
3769400
3ecb980
4fe58f2
a55bff8
58922e1
cda8275
5f93717
39e55fe
366c77a
33dc3bd
865f213
2570eb8
bfd3945
4fb77e1
8cf0c4a
21b080d
4fe5fe3
2517afa
d32cd6a
53e4c4e
568fefe
76305a9
5459622
1ea53ef
dbca557
d444ad3
2570f54
f6ce011
8fb13bb
e23a589
e8c74f6
b99af10
4dd5bf4
01d90a6
14609cf
127cb41
df48db4
37a46d6
2bd05da
364ce34
3a863ed
406641b
0e512fc
da02b01
c043b95
d4da504
3b12f11
252d399
1debe02
573c80b
f9c4546
40d1543
7071618
81f5e71
4fcd913
757a486
01e6f6e
0677f2f
0eecbd8
f78adee
e702a88
33e1588
97ff491
b6d6201
5fa74f6
17ddd8f
05ef46a
254627d
b2558fc
16437c3
8296ea0
2223415
def5957
86e5308
bdd0928
b2564cc
c0c4a72
671afca
06f5c23
fd78faf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For naming conventions, I'd suggest we remove
FUSE_
from the constant names and addDEFAULT_
to all default values for clarity.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's config entity. the default value is a member data. so the entity name use default is not good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writing this file needs a root account, is that okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need to write the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implies that we have some constraints on the values of
entity.module
,entity.name
, right?For example, they cannot contain
.
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no such restriction. In our configuration class, we can set the configuration name corresponding to the variable name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this error message more actionable?