[#5872] feat(client): Add model management Java client API #6003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
force-pushed
the
issue-5872
branch
from
4c36e5b to
8fb1a67
Compare
tengqm
reviewed
Dec 31, 2024
| } | ||
|
|
||
| @Override | ||
| public boolean deleteModel(NameIdentifier ident) { |
There was a problem hiding this comment.
When we have register..., I'm expecting a deregister... rather than a delete....
There was a problem hiding this comment.
I refer this from other system's design (https://docs.unitycatalog.io/usage/models/#deleting-registered-models-and-model-versions), I think it is fine and easy to understand.
| Preconditions.checkArgument(StringUtils.isNotBlank(name), "name must not be blank"); | ||
| Preconditions.checkArgument(type != null, "type must not be null"); | ||
| Preconditions.checkArgument(StringUtils.isNotBlank(provider), "provider must not be blank"); | ||
| Preconditions.checkArgument(audit != null, "audit must not be null"); |
There was a problem hiding this comment.
This sounds like a little bit too strict?
There was a problem hiding this comment.
They are all the necessary variables, it cannot work if one is missing.
mchades
reviewed
Dec 31, 2024
clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelVersion.java
Outdated
Show resolved
Hide resolved
jerryshao
force-pushed
the
issue-5872
branch
from
2e36c06 to
08b0f59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds the Java client API for model management.
Why are the changes needed?
This is a part of work of model management.
Fix: #5872
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT added.