[#5987] improvement: Add more configurations for the config API #5999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @LauraXia123 |
mchades
previously approved these changes
Dec 26, 2024
|
Should the value be |
You are right. It should be |
mchades
dismissed
their stale review
the value should be in json type not json string
|
cc @lw-yang |
mchades
reviewed
Dec 26, 2024
|
@tengqm Do you have other suggestion? |
LGTM, although I was thinking of a JSON type configuration file for this purpose. |
We can expose more config options in the future. This config option is used for front end display. It's also useful to users if they use API to get the configurations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add more configurations for the config API
Why are the changes needed?
Fix #5987
Front end can use this config option to optimize the user experience.
Does this PR introduce any user-facing change?
No.
How was this patch tested?