-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5966] improvment(authorization): Add path based securable object and user group mapping interface #5967
Open
yuqi1129
wants to merge
3
commits into
apache:main
Choose a base branch
from
yuqi1129:path_base_interface
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+86
−16
Open
[#5966] improvment(authorization): Add path based securable object and user group mapping interface #5967
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
64 changes: 64 additions & 0 deletions
64
...java/org/apache/gravitino/authorization/common/AuthorizationUserGroupMappingProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
* | ||
*/ | ||
|
||
package org.apache.gravitino.authorization.common; | ||
|
||
import java.util.Map; | ||
|
||
/** | ||
* The AuthorizationUserGroupMappingProvider interface defines the public API for mapping Gravitino | ||
* users and groups to the that in underlying data source system. | ||
* | ||
* <p>Typically, the users and group names in Gravitino are the same as the underlying data source. | ||
* However, in some cases, the user and group names in Gravitino may be different from the | ||
* underlying data source. For instance, in GCP IAM, the username is the email address or the | ||
* service account. So the user group mapping provider can be used to map the Gravitino username to | ||
* the email address or service account. | ||
*/ | ||
public interface AuthorizationUserGroupMappingProvider { | ||
|
||
/** | ||
* Initialize the user group mapping provider with the configuration. | ||
* | ||
* @param config The configuration map for the user group mapping provider. | ||
*/ | ||
default void initialize(Map<String, String> config) {} | ||
|
||
/** | ||
* Get the username from the underlying data source based on the Gravitino username For instance, | ||
* in GCP IAM, the username is the email address or the service account. | ||
* | ||
* @param gravitinoUserName The Gravitino username. | ||
* @return The username from the underlying data source. | ||
*/ | ||
default String getUserName(String gravitinoUserName) { | ||
return gravitinoUserName; | ||
} | ||
|
||
/** | ||
* Get the group name from the underlying data source based on the Gravitino group name. | ||
* | ||
* @param gravitinoGroupName The Gravitino group name. | ||
* @return The group name from the underlying data source. | ||
*/ | ||
default String getGroupName(String gravitinoGroupName) { | ||
return gravitinoGroupName; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xunliu Please take a look and let me know if this is acceptable to you.