-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5886] feat (gvfs-fuse): Implement an in-memory file system #5915
Conversation
I think it's time to organize the code hierarchy not flatten all the code in the |
// `XXXFileSystem is a filesystem that allows you to implement file access through your own extensions. | ||
let _ = signal::ctrl_c().await; | ||
info!("Received Ctrl+C, Unmounting gvfs..."); | ||
gvfs_unmount().await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what will happen if the process crashed without invoking gvfs_unmount
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mount point does't unmounted, users need to umount the directory manually.
Typical FUSE programs do not run in the foreground, and exiting with Ctrl+C is not the standard practice.
This mode is used for testing and debugging.
|
||
let results: Vec<FileStat> = file_map | ||
.iter() | ||
.filter(|x| path_in_dir(path, x.0)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please filter out the files in sub directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix
Wait until the subsequent PRs are merged before organizing. Doing the later PRs now would lead to significant conflicts. |
What changes were proposed in this pull request?
Implement an in-memory filesystem for testing and validating the FUSE framework. You need to implement the PathFilesystem trait and support basic file and directory operations:
Why are the changes needed?
Fix: #5886
Does this PR introduce any user-facing change?
No
How was this patch tested?
IT