[#5730] feat(client-python): Add sorts expression #5879
Conversation
|
hi @SophieTech88 I help you improve this PR, Please review it, Thanks. |
|
|
||
| @staticmethod | ||
| def ascending(expression: Expression) -> SortImpl: | ||
| """Creates a sort order with ascending direction and nulls first.""" |
There was a problem hiding this comment.
@Xun This document is slightly different from Java client, do we need to align these two docs ?
/**
* Create a sort order by the given expression with the ascending sort direction and nulls first
* ordering.
*
* @param expression The expression to sort by
* @return The created sort order
*/
|
|
||
| @staticmethod | ||
| def descending(expression: Expression) -> SortImpl: | ||
| """Creates a sort order with descending direction and nulls last.""" |
| direction: SortDirection, | ||
| null_ordering: NullOrdering = None, | ||
| ) -> SortImpl: | ||
| """Creates a sort order with the given direction and optionally specified null ordering.""" |
|
overall, LGTM |
| _direction: str | ||
| _default_null_ordering: NullOrdering |
There was a problem hiding this comment.
These lines should be removed.
There was a problem hiding this comment.
I know that Python can derive member variables, but I feel like showing all member variables explicitly. It will make the code easier to read.
There was a problem hiding this comment.
I know that Python can derive member variables, but I feel like showing all member variables explicitly. It will make the code easier to read.
| _expression: Expression | ||
| _direction: SortDirection | ||
| _null_ordering: NullOrdering |
There was a problem hiding this comment.
I know that Python can derive member variables, but I feel like showing all member variables explicitly. It will make the code easier to read.
There was a problem hiding this comment.
What you define here are class properties, not instance properties.
Python is different from Java on this.
There was a problem hiding this comment.
OH, you are right. I will fix this problem.
|
overall LGTM! |
### What changes were proposed in this pull request? Implement sorts expression in python client, add unit test. ### Why are the changes needed? We need to support the sorts expressions in python client Fix: apache#5730 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Need to pass all unit tests. --------- Co-authored-by: Xun <[email protected]> Co-authored-by: Xun <[email protected]>
What changes were proposed in this pull request?
Implement sorts expression in python client, add unit test.
Why are the changes needed?
We need to support the sorts expressions in python client
Fix: #5730
Does this PR introduce any user-facing change?
No
How was this patch tested?
Need to pass all unit tests.