Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#5867] feat(flink-connector) Improve flink connector #5868

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[#5867] feat(flink-connector) Improve flink connector #5868

merged 1 commit into from
Dec 19, 2024

Conversation

sunxiaojian
Copy link
Contributor

@sunxiaojian sunxiaojian commented Dec 16, 2024 •
edited
Loading

What changes were proposed in this pull request?

  1. Remove useless code
  2. Optimize the logic of the store, and when adding connector support, there is no need to modify the logic of the store.

Why are the changes needed?

Fix : #5867

Does this PR introduce any user-facing change?

No.

How was this patch tested?

FlinkHiveCatalogIT

@sunxiaojian
Copy link
Contributor Author

@xunliu @coolderli PTAL

@tengqm
Copy link
Contributor

tengqm commented Dec 16, 2024

LGTM.

@FANNG1
Copy link
Contributor

FANNG1 commented Dec 17, 2024

Overall LGTM, @sunxiaojian could you add more information in the issue description about what and why you are changing? @coolderli do you have time to review this PR?

@jerryshao
Copy link
Contributor

@coolderli would you please help to review this PR? Thanks.

@sunxiaojian
Copy link
Contributor Author

Overall LGTM, @sunxiaojian could you add more information in the issue description about what and why you are changing? @coolderli do you have time to review this PR?

  1. Remove useless code
  2. Optimize the logic of the store, and when adding connector support, there is no need to modify the logic of the store.

@sunxiaojian sunxiaojian force-pushed the improve-flink branch 2 times, most recently from a9a2ce0 to 2a164b2 Compare December 17, 2024 15:04
@sunxiaojian sunxiaojian force-pushed the improve-flink branch 2 times, most recently from c992b41 to 79b81dd Compare December 18, 2024 03:54
@FANNG1 FANNG1 mentioned this pull request Dec 18, 2024
Open
@FANNG1
Copy link
Contributor

FANNG1 commented Dec 18, 2024

If no other view comments, plan to merge this PR tomorrow.

@hdygxsj
Copy link
Contributor

hdygxsj commented Dec 18, 2024

LGTM @FANNG1

@jerryshao
Copy link
Contributor

@sunxiaojian would you please update the PR description to follow our PR pattern? Thanks a lot.

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian would you please update the PR description to follow our PR pattern? Thanks a lot.

updated

@FANNG1 FANNG1 merged commit 9695c28 into apache:main Dec 19, 2024
23 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Dec 19, 2024

Thanks @sunxiaojian for the contribution and @tengqm @hdygxsj for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FANNG1 FANNG1 FANNG1 approved these changes

@coolderli coolderli Awaiting requested review from coolderli

Assignees

@sunxiaojian sunxiaojian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improvement] Improve flink connector
5 participants
@sunxiaojian @tengqm @FANNG1 @jerryshao @hdygxsj