Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5832] Minor: metalake error message #5843

Closed
wants to merge 1 commit into from
Closed

[#5832] Minor: metalake error message #5843

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/src/main/java/org/apache/gravitino/dto/requests/MetalakeCreateRequest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@ public MetalakeCreateRequest(String name, String comment, Map<String, String> pr
@Override
public void validate() throws IllegalArgumentException {
Preconditions.checkArgument(
StringUtils.isNotBlank(name), "\"name\" field is required and cannot be empty");
StringUtils.isNotBlank(name), "\"name\" field is required. Please provide a valid name for the Metalake. It cannot be empty or only whitespace.");
Copy link
Member

@justinmclean justinmclean Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with this change is that it changes the Java API, not the Gravitino CLI. In the Java API context, this error message is correct, in the CLI context, the message could be more helpful. The change needs to be made in the CLI code not in the Java API code.

}
}
Loading