Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Revise the glossary documentation #5837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Dec 11, 2024

What changes were proposed in this pull request?

This PR fixes the glossary docs.

Why are the changes needed?

The glossary is reordered for quick reference.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@justinmclean
Copy link
Member

Please do not break sentences over multiple lines as this breaks some tooling.

docs/glossary.md Outdated Show resolved Hide resolved
@tengqm
Copy link
Contributor Author

tengqm commented Dec 12, 2024

Please do not break sentences over multiple lines as this breaks some tooling.

No. I don't agree with this. Long lines are hard to review, hard to maintain, hard to read even in an IDE.

@justinmclean
Copy link
Member

justinmclean commented Dec 12, 2024

IDE wrap lines, so that's not really an issue. As I explained elsewhere, if you break up lines, tools like grammar and style checkers that we use will not work. Some people who contribute to this project don't have English as their first language and rely heavily on these tools.

@tengqm
Copy link
Contributor Author

tengqm commented Dec 12, 2024

IDE wrap lines, so that's not really an issue. As I explained elsewhere, if you break up lines, tools like grammar and style checkers that we use will not work. Some people who contribute to this project don't have English as their first language and rely heavily on these tools.

No. It is an issue, and a very annoying issue. Please refer this comment.
Different people (including developers) see different things (I'm not using your IDE),
that is an additional issue. This is like the TAB usage scenario.
Grammar or style checker is not a valid reason for this change.
I was not encouraging breaking a long line in the middle.
I was suggesting to break long lines APPROPRIATELY, at statement boundary, at punctuation.

@tengqm
Copy link
Contributor Author

tengqm commented Dec 12, 2024

Check this change and tell me ... how this change is breaking your IDE syntax checker?
Can you elaborate how this "line breaks" hurts anything?

image

@justinmclean
Copy link
Member

That change is fine. The issue occurs when you break up a sentence over several lines.

@justinmclean
Copy link
Member

Changes like this cause the issue:
image

@tengqm
Copy link
Contributor Author

tengqm commented Dec 12, 2024

Okay, let me revise this further. Breaking those long sentences to simple English.

@jerryshao
Copy link
Contributor

@justinmclean would you please help to review again? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants