[#480] test(lakehouse-iceberg): support JdbcCatalog for Iceberg REST service IT #520
Conversation
Code Coverage Report
Files
|
|
after #501 , mysql jar is automatically downloaded by Graviton, we could merge this pr |
| + IcebergRESTService.SERVICE_NAME | ||
| + "." | ||
| + IcebergConfig.CATALOG_WAREHOUSE.getKey(), | ||
| "file:///tmp/user/hive/warehouse-mysql/"); |
There was a problem hiding this comment.
Do you need to change the name to not specify "mysql". Also Do you need to change to HDFS since @mchades 's PR is ready?
There was a problem hiding this comment.
plan to propose a new PR to change localfs to HDFS for JdbcCatalog and HiveCatalog
There was a problem hiding this comment.
So please create a new issue to track this thing.
There was a problem hiding this comment.
create #530 to track
...-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/IcebergConfig.java
Outdated
Show resolved
Hide resolved
|
|
||
| public static final ConfigEntry<String> JDBC_PASSWORD = | ||
| new ConfigBuilder(ICEBERG_JDBC_PASSWORD) | ||
| .doc("The password of the Jdbc") |
There was a problem hiding this comment.
using Jdbc connection
...-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/IcebergConfig.java
Outdated
Show resolved
Hide resolved
| configMap.put( | ||
| AuxiliaryServiceManager.GRAVITINO_AUX_SERVICE_PREFIX | ||
| + IcebergRESTService.SERVICE_NAME | ||
| + "." |
There was a problem hiding this comment.
I suggest introducing a temporary variation, as it has been repeated several times.
There was a problem hiding this comment.
I think it's ok to keep this, since this is a test code.
What changes were proposed in this pull request?
support JdbcCatalog for Iceberg REST service IT
Why are the changes needed?
Fix: #480
Does this PR introduce any user-facing change?
No
How was this patch tested?
add Jdbc IT