[#5124][#5146] feat(auth-ranger): Ranger plugin should support rename operation #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
force-pushed
the
issue-5124
branch
2 times, most recently
from
a248f11 to
d9466d1
Compare
xunliu
changed the title
jerqi
reviewed
Oct 25, 2024
api/src/main/java/org/apache/gravitino/authorization/MetadataObjectChange.java
Show resolved
Hide resolved
xunliu
force-pushed
the
issue-5124
branch
5 times, most recently
from
e54ee7c to
bb20a1e
Compare
jerqi
reviewed
Oct 29, 2024
| } | ||
|
|
||
| /** | ||
| * Remove the TABLE, Need to rename these the relevant policies, `*.{table}`, `*.{table}.{column}` |
jerqi
reviewed
Oct 29, 2024
| } | ||
|
|
||
| /** | ||
| * Remove the SCHEMA, Need to rename these the relevant policies, `{schema}`, `{schema}.*`, |
FANNG1
reviewed
Oct 30, 2024
| * @return return a metadataObject. | ||
| */ | ||
| public MetadataObject getMetadataObject() { | ||
| return this.metadataObject; |
| * | ||
| * @return return a metadataObject. | ||
| */ | ||
| public MetadataObject getMetadataObject() { |
There was a problem hiding this comment.
remove get from method name?
| /** | ||
| * IF remove the SCHEMA, Need to remove these the relevant policies, `{schema}`, `{schema}.*`, | ||
| * `{schema}.*.*` <br> | ||
| * IF remove the TABLE, Need to remove these the relevant policies, `{schema}.*`, `{schema}.*.*` |
FANNG1
reviewed
Oct 30, 2024
| * | ||
| * @return return a metadataObject object. | ||
| */ | ||
| public MetadataObject getNewMetadataObject() { |
FANNG1
reviewed
Oct 30, 2024
| * | ||
| * @return return a metadataObject. | ||
| */ | ||
| public MetadataObject getMetadataObject() { |
|
LGTM except minor comments |
FANNG1
approved these changes
Oct 30, 2024
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…pport rename operation (apache#5176) ### What changes were proposed in this pull request? Add rename a securable object in the RoleChange. ### Why are the changes needed? Fix: apache#5124 apache#5146 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Add ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add rename a securable object in the RoleChange.
Why are the changes needed?
Fix: #5124 #5146
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Add ITs.