[#5173] feat(hadoop-catlog): Support OSS fileset for Gravitino. #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerryshao
reviewed
Oct 18, 2024
| htrace-core4 = { group = "org.apache.htrace", name = "htrace-core4", version.ref = "htrace-core4" } | ||
| airlift-json = { group = "io.airlift", name = "json", version.ref = "airlift-json"} | ||
| airlift-resolver = { group = "io.airlift.resolver", name = "resolver", version.ref = "airlift-resolver"} | ||
| httpclient5 = { group = "org.apache.httpcomponents.client5", name = "httpclient5", version.ref = "httpclient5" } | ||
| mockserver-netty = { group = "org.mock-server", name = "mockserver-netty", version.ref = "mockserver" } | ||
| mockserver-client-java = { group = "org.mock-server", name = "mockserver-client-java", version.ref = "mockserver" } | ||
| commons-lang = { group = "commons-lang", name = "commons-lang", version.ref = "commons-lang" } |
There was a problem hiding this comment.
You need to update the LICENSE.bin for your new added dependency.
There was a problem hiding this comment.
I have confirmed it and it seems there already exists the content in the LICENSE.bin
Line 253 in 93cdbc2
jerryshao
reviewed
Oct 18, 2024
| // org.apache.hadoop.fs.aliyun.oss.AliyunOSSFileSystem.initialize(AliyunOSSFileSystem.java:323) | ||
| // org.apache.hadoop.fs.FileSystem.createFileSystem(FileSystem.java:3611) | ||
|
|
||
| implementation(libs.commons.lang) |
There was a problem hiding this comment.
Is it possible to shade this jar?
There was a problem hiding this comment.
I think so, the package will be shaded in the jar gravitino-aliyun-bundle.
There was a problem hiding this comment.
It is introduced by you, so you have to shade it.
yuqi1129
commented
Oct 18, 2024
| @@ -282,6 +282,8 @@ | |||
| ApacheDS I18n | |||
| ApacheDS Protocol Kerberos Codec | |||
| Apache Hadoop | |||
| Apache Hadoop Aliyun connector | |||
| Apache Hadoop GCS connector | |||
There was a problem hiding this comment.
@jerryshao
Please take a look if this change is acceptable.
jerryshao
approved these changes
Oct 18, 2024
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…apache#5174) ### What changes were proposed in this pull request? Add OSS fileset support. ### Why are the changes needed? OSS is widely used in China and Asia. Fix: apache#5173 ### Does this PR introduce _any_ user-facing change? N/A. ### How was this patch tested? Test Locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add OSS fileset support.
Why are the changes needed?
OSS is widely used in China and Asia.
Fix: #5173
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
Test Locally.