[#5141][#5142][#5143] web(ui): Add support for creating, editing, and deleting schema #5164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting, editing, and deleting schema
jerryshao
changed the title
jerryshao
reviewed
Oct 21, 2024
Comment on lines
271
to
292
| {!isKafkaSchema && ( | ||
| <IconButton | ||
| title='Edit' | ||
| size='small' | ||
| sx={{ color: theme => theme.palette.text.secondary }} | ||
| onClick={() => handleShowEditDialog({ row, type: row.node })} | ||
| data-refer={`edit-entity-${row.name}`} | ||
| > | ||
| <EditIcon /> | ||
| </IconButton> | ||
| )} | ||
|
|
||
| {!isKafkaSchema && ( | ||
| <IconButton | ||
| title='Delete' | ||
| size='small' | ||
| sx={{ color: theme => theme.palette.error.light }} | ||
| onClick={() => handleDelete({ name: row.name, type: row.node, catalogType: row.type })} | ||
| data-refer={`delete-entity-${row.name}`} | ||
| > | ||
| <DeleteIcon /> | ||
| </IconButton> |
There was a problem hiding this comment.
Currently, we cannot edit or delete hudi schema, am I right @mchades ?
jerryshao
reviewed
Oct 22, 2024
| const searchParams = useSearchParams() | ||
| const [isShowBtn, setBtnVisiable] = useState(true) | ||
| const [isShowSchemaBtn, setSchemaBtnVisiable] = useState(false) |
There was a problem hiding this comment.
I think it should be "Visible", right?
There was a problem hiding this comment.
It's visible when view the schema page, it's unvisible when view other pages.
The judgment condition is implemented in lines 54 to 57.
There was a problem hiding this comment.
I mean "visiable" is a typo we need to fix.
LauraXia123
force-pushed
the
issue-5141
branch
from
8289d30 to
2672742
Compare
jerryshao
approved these changes
Oct 22, 2024
mplmoknijb
pushed a commit
to mplmoknijb/gravitino
that referenced
this pull request
Nov 6, 2024
…ting, editing, and deleting schema (apache#5164) ### What changes were proposed in this pull request? Add support for creating, editing, and deleting schema <img width="831" alt="image" src="https://github.com/user-attachments/assets/8194b0e1-0da4-4ed3-967a-3f7467745681"> <img width="1168" alt="image" src="https://github.com/user-attachments/assets/e4735560-c928-4bbc-8452-aab82a0559b1"> <img width="613" alt="image" src="https://github.com/user-attachments/assets/90c04707-a0be-47dc-a425-233759eab84f"> <img width="752" alt="image" src="https://github.com/user-attachments/assets/59ec3f21-b3f9-4a2d-bf0b-44c396db1555"> <img width="954" alt="image" src="https://github.com/user-attachments/assets/6b7993c1-9848-435e-8cc0-874f3a70195b"> <img width="1149" alt="image" src="https://github.com/user-attachments/assets/889287f1-d4e9-45b2-8e7b-18970b42f108"> ### Why are the changes needed? N/A Fix: apache#5141, apache#5142, apache#5143 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? manually
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add support for creating, editing, and deleting schema
Why are the changes needed?
N/A
Fix: #5141, #5142, #5143
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
manually