Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5120] improvement(docs): Add the document of metadata object ownership #5123

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

jerqi
Copy link
Contributor

@jerqi jerqi commented Oct 12, 2024

What changes were proposed in this pull request?

Add the document of metadata object ownership

Why are the changes needed?

Fix: #5120

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Just document.

@jerqi jerqi self-assigned this Oct 12, 2024
@jerqi jerqi requested a review from xunliu October 14, 2024 02:23
@@ -90,6 +90,18 @@ The owner of each entity has implicit administrative class privilege, for exampl
Only the Owner of a securable object can fully manage that resource.
If a securable object needs to be managed by more than one person at the same time, the owner is assigned to a user group.

The metadata object which supports ownership is as follows:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"that supports..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which or that is ok. In America, more people prefer using that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really should be "The metadata objects that support ownership are:". You could possibly leave in "are as follows" but it's unnecessarily verbose.

@jerryshao jerryshao merged commit 327e876 into apache:main Oct 14, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Add the document of metadata object ownership
3 participants