[#4968] improvement(api): Unify the modification behavior of the comment field #5121
Conversation
koonchen
changed the title
koonchen
force-pushed
the
issue#4968
branch
2 times, most recently
from
9c3c482 to
06681cd
Compare
|
@koonchen could you plz update the code to make the CI pass? |
OK, I'm a little bit busy these days, I'll take some time this week to deal with it |
koonchen
force-pushed
the
issue#4968
branch
2 times, most recently
from
a664656 to
3fae0cc
Compare
|
@mchades PTAL |
...doop/src/test/java/org/apache/gravitino/catalog/hadoop/integration/test/HadoopCatalogIT.java
Outdated
Show resolved
Hide resolved
|
@koonchen could you plz resolve the comments? |
|
ok, I handle it on the weekend |
koonchen
force-pushed
the
issue#4968
branch
2 times, most recently
from
fa2fd28 to
c7446a1
Compare
|
@mchades I have been traveling these days. Thank you for your help. You are a good mentor PTAL |
|
plz fix the CI |
|
I noticed that you only modified the behavior of Fileset. The Metalake, Catalog, Table, and Topic also need to be changed. |
|
I want to include this change in 0.7, in order to catch up with the release of 0.7. If you are pressed for time and do not mind, may I take over next week to finish the rest of it based on this PR? |
|
@mchades Thanks, I can still give it a try tomorrow, Catalog Metalake Table Tag Topic, has been modified to allow null or empty string for |
Sorry, I made a mistake. I will review it as soon as possible |
...atalog-hadoop/src/main/java/org/apache/gravitino/catalog/hadoop/HadoopCatalogOperations.java
Outdated
Show resolved
Hide resolved
clients/client-java/src/main/java/org/apache/gravitino/client/DTOConverters.java
Outdated
Show resolved
Hide resolved
koonchen
force-pushed
the
issue#4968
branch
5 times, most recently
from
9ed1ecd to
b23de8f
Compare
|
@mchades PTAL |
…ent field (#5121) ### What changes were proposed in this pull request? - deprecated the removeComment change - the new comment of updateComment supports null and empty string ### Why are the changes needed? Fix: #4968 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Pass existing tests Co-authored-by: chenzeping.ricco <[email protected]>
…e comment field (apache#5121) ### What changes were proposed in this pull request? - deprecated the removeComment change - the new comment of updateComment supports null and empty string ### Why are the changes needed? Fix: apache#4968 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? Pass existing tests Co-authored-by: chenzeping.ricco <[email protected]>
What changes were proposed in this pull request?
Why are the changes needed?
Fix: #4968
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Pass existing tests