[#5059] Add commands to create, delete and modify metalakes, catalogs and schema in CLI. #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java
|
@shaofengshi @diqiu50 @yuqi1129 or @mchades if you could review this that would be appreciated. Note that this also includes changes from #5057, as that has not been merged yet. |
lisancao
reviewed
Oct 16, 2024
lisancao
reviewed
Oct 16, 2024
# Conflicts: # clients/cli/README.md # clients/cli/src/main/java/org/apache/gravitino/cli/CommandActions.java # clients/cli/src/main/java/org/apache/gravitino/cli/ErrorMessages.java # clients/cli/src/main/java/org/apache/gravitino/cli/FullName.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoCommandLine.java # clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java # clients/cli/src/main/java/org/apache/gravitino/cli/Main.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestCommandActions.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestCommandEntities.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestFulllName.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestGravitinoOptions.java # clients/cli/src/test/java/org/apache/gravitino/cli/TestMain.java
|
The changes from #5057 have been merged and the branch synced with main. |
|
@shaofengshi this is ready for review, @diqiu50 @yuqi1129 or @mchades if you could review this as well, that would be appreciated. |
justinmclean
changed the title
shaofengshi
reviewed
Oct 31, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/GravitinoOptions.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Oct 31, 2024
shaofengshi
reviewed
Oct 31, 2024
shaofengshi
reviewed
Oct 31, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/Providers.java
Outdated
Show resolved
Hide resolved
shaofengshi
reviewed
Oct 31, 2024
clients/cli/src/main/java/org/apache/gravitino/cli/commands/ListMetalakeProperties.java
Show resolved
Hide resolved
shaofengshi
reviewed
Oct 31, 2024
shaofengshi
reviewed
Oct 31, 2024
shaofengshi
reviewed
Oct 31, 2024
jerryshao
reviewed
Oct 31, 2024
…pecify properties as a list of key-value pairs.
|
@jerryshao @shaofengshi All changes have been made can you please review this again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add commands to create, delete and modify metalakes, catalogs and schema.
Why are the changes needed?
stage 2 of the CLI.
Fix: #5059
Does this PR introduce any user-facing change?
Add new CLI features.
How was this patch tested?
Tests pass locally.