[#5112] feat(core): support pre event for event listener systems #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
changed the title
FANNG1
changed the title
FANNG1
force-pushed
the
pre_event
branch
2 times, most recently
from
9740528 to
269e7c6
Compare
jerryshao
reviewed
Oct 14, 2024
| * | ||
| * <p>This method provides a hook for pre-operation event processing, any changes you make to the | ||
| * resources during the event will be reflected in the operations that follow. You must set mode | ||
| * to SYNC to process pre events. |
There was a problem hiding this comment.
Why do we need to set SYNC to support pre events?
jerryshao
reviewed
Oct 14, 2024
| @@ -35,25 +37,45 @@ public class EventBus { | |||
| // which are meant for synchronous event listening, or AsyncQueueListener, designed for | |||
| // asynchronous event processing. | |||
| private final List<EventListenerPlugin> postEventListeners; | |||
| // Only contain sync EventListenerPlugins. | |||
| private final List<EventListenerPlugin> preEventListeners; | |||
There was a problem hiding this comment.
Why do we need to have 2 listeners for pre and post event separately?
|
@jerryshao please help to review again |
jerryshao
reviewed
Oct 15, 2024
| */ | ||
| void onPostEvent(Event event) throws RuntimeException; | ||
| default void onPostEvent(Event postEvent) throws RuntimeException {} |
There was a problem hiding this comment.
Why do we change to default?
There was a problem hiding this comment.
after supporting pre event, the user who only interest on pre event, could only implement onPreEvent interface, no need to implement onPostEvent interface
jerryshao
reviewed
Oct 15, 2024
| * Handles events generated after the completion of an operation. Implementers are responsible for | ||
| * processing these events, which may involve additional logic to respond to the operation | ||
| * outcomes. | ||
| * Handles events generated after the completion of an operation. |
jerryshao
reviewed
Oct 15, 2024
| default void onPostEvent(Event postEvent) throws RuntimeException {} | ||
|
|
||
| /** | ||
| * Handles pre events generated before the operation. |
jerryshao
reviewed
Oct 15, 2024
Comment on lines
80
to
85
| private void dispatchPostEvent(Event postEvent) { | ||
| eventListeners.forEach(postEventListener -> postEventListener.onPostEvent(postEvent)); | ||
| } | ||
|
|
||
| private void dispatchPreEvent(PreEvent preEvent) throws ForbiddenException { | ||
| eventListeners.forEach(preEventListener -> preEventListener.onPreEvent(preEvent)); |
There was a problem hiding this comment.
Actually, we don't differentiate pre or post event listeners, the code here is a little confusing. We can change to:
private void dispatchPostEvent(Event postEvent) {
eventListeners.forEach(listener -> listener.onPostEvent(postEvent));
}
jerryshao
reviewed
Oct 15, 2024
Comment on lines
86
to
90
| LOG.warn( | ||
| "Event listener {} process pre event {} failed, will skip the operation.", | ||
| listenerName, | ||
| preEvent.getClass().getSimpleName(), | ||
| e); |
There was a problem hiding this comment.
I think you can extract the common part here to simplify the code.
jerryshao
reviewed
Oct 15, 2024
| * Handles pre events generated before the operation. | ||
| * | ||
| * <p>This method handles pre-operation events in SYNC or ASYNC mode, any changes to resources in | ||
| * the event will inflect the subsequent operations. |
jerryshao
reviewed
Oct 15, 2024
Comment on lines
118
to
120
| * @throws ForbiddenException The operation will be skipped if and only if throwing {@code | ||
| * org.apache.gravitino.exceptions.ForbiddenException} and the event listener is SYNC mode, | ||
| * the exception will be ignored in other conditions. |
There was a problem hiding this comment.
Can you please explain about the exception here, how you handle this?
jerryshao
approved these changes
Oct 15, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support pre event for event listener systems
PreEventto represent Pre event and onlySYNCevent listeners could processPreEventEventas post event to keep compatibility.EventBusdispatch event to corresponding event listeners.Why are the changes needed?
Fix: #5112
Does this PR introduce any user-facing change?
no
How was this patch tested?
add UT