[#5082] fix(catalog): fix clean bug after create catalog failed #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
reviewed
Oct 10, 2024
| } finally { | ||
| if (!createSuccess) { | ||
| if (needClean) { | ||
| // Clean up the default schema under the catalog if creation failed |
There was a problem hiding this comment.
// Clean up the default schema under the catalog if creation failed
I believe this scenario is only used for kafka catalog currently, so can you add more information about it?
There was a problem hiding this comment.
This has nothing to do with the Kafka catalog, the comment has been updated
yuqi1129
approved these changes
Oct 10, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Oct 10, 2024
### What changes were proposed in this pull request? - not clean catalog if catalog already exists ### Why are the changes needed? we will clean the catalog when the creation fails, but if the catalog already exists it will also be dropped which is unexpected. Fix: #5082 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? tests added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
we will clean the catalog when the creation fails, but if the catalog already exists it will also be dropped which is unexpected.
Fix: #5082
Does this PR introduce any user-facing change?
no
How was this patch tested?
tests added